Skip to content
Permalink
Browse files

Avoid running problematic static offset tests in IE8 on the swarm.

  • Loading branch information
dmethvin committed Jul 4, 2012
1 parent cef4161 commit 5c60e334d35df7065b7c09073f5aeaed58fd427d
Showing with 10 additions and 5 deletions.
  1. +10 −5 test/unit/offset.js
@@ -206,15 +206,18 @@ testIframe("offset/static", "static", function( jQuery ) {
expect(80);

// IE is collapsing the top margin of 1px; detect and adjust accordingly
var ie = jQuery("#static-1").offset().top === 6;
var ie = jQuery("#static-1").offset().top === 6,
swarmy = document.documentMode === 8 && window.location.search.indexOf("swarmURL") >= 0;

// get offset
var tests = [
{ id: "#static-1", top: ie ? 6 : 7, left: 7 },
{ id: "#static-1-1", top: ie ? 13 : 15, left: 15 },
{ id: "#static-1-1-1", top: ie ? 20 : 23, left: 23 },
{ id: "#static-2", top: ie ? 121 : 122, left: 7 }
{ id: "#static-1-1-1", top: ie ? 20 : 23, left: 23 }
];
if ( !swarmy ) {
tests.push({ id: "#static-2", top: ie ? 121 : 122, left: 7 });
}
jQuery.each( tests, function() {
equal( jQuery( this.id ).offset().top, this.top, "jQuery('" + this.id + "').offset().top" );
equal( jQuery( this.id ).offset().left, this.left, "jQuery('" + this.id + "').offset().left" );
@@ -225,9 +228,11 @@ testIframe("offset/static", "static", function( jQuery ) {
tests = [
{ id: "#static-1", top: ie ? 5 : 6, left: 6 },
{ id: "#static-1-1", top: ie ? 12 : 14, left: 14 },
{ id: "#static-1-1-1", top: ie ? 19 : 22, left: 22 },
{ id: "#static-2", top: ie ? 120 : 121, left: 6 }
{ id: "#static-1-1-1", top: ie ? 19 : 22, left: 22 }
];
if ( !swarmy ) {
tests.push({ id: "#static-2", top: ie ? 120 : 121, left: 6 });
}
jQuery.each( tests, function() {
equal( jQuery( this.id ).position().top, this.top, "jQuery('" + this.top + "').position().top" );
equal( jQuery( this.id ).position().left, this.left, "jQuery('" + this.left +"').position().left" );

2 comments on commit 5c60e33

@mikesherov

This comment has been minimized.

Copy link
Member

mikesherov replied Jul 4, 2012

this makes me totally sad.

@dmethvin

This comment has been minimized.

Copy link
Member Author

dmethvin replied Jul 4, 2012

Me too...I didn't know of an easy way to see whether this might fix it so we'll see if this really eliminates the fail or just pushes it elsewhere.

Please sign in to comment.
You can’t perform that action at this time.