Skip to content
Permalink
Browse files

Trigger onclick handlers of links

  • Loading branch information
brandonaaron committed Apr 21, 2008
1 parent a9fe9a2 commit 5d033dba02fc1ffe1398cdaf0e9d402fc75e13f0
Showing with 10 additions and 3 deletions.
  1. +2 −2 src/event.js
  2. +8 −1 test/unit/event.js
@@ -203,8 +203,8 @@ jQuery.event = {
if ( jQuery.isFunction( jQuery.data(elem, "handle") ) )
val = jQuery.data(elem, "handle").apply( elem, data );

// Handle triggering native .onfoo handlers
if ( !fn && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
// Handle triggering native .onfoo handlers (and on links since we don't call .click() for links)
if ( (!fn || (jQuery.nodeName(elem, 'a') && type == "click")) && elem["on"+type] && elem["on"+type].apply( elem, data ) === false )
val = false;

// Extra functions don't get the custom event object
@@ -113,7 +113,7 @@ test("bind(), namespaced events, cloned events", function() {
});

test("click()", function() {
expect(4);
expect(5);
$('<li><a href="#">Change location</a></li>').prependTo('#firstUL').find('a').bind('click', function() {
var close = $('spanx', this); // same with $(this).find('span');
ok( close.length == 0, "Context element does not exist, length must be zero" );
@@ -131,6 +131,13 @@ test("click()", function() {
};
$('#firstp').click();
ok( counter == 1, "Check that click, triggers onclick event handler also" );

var clickCounter = 0;
$('#simon1')[0].onclick = function(event) {
clickCounter++;
};
$('#simon1').click();
ok( clickCounter == 1, "Check that click, triggers onclick event handler on an a tag also" );
});

test("unbind(event)", function() {

0 comments on commit 5d033db

Please sign in to comment.
You can’t perform that action at this time.