Space in front of width
Please be sure to review the latest version of the code before providing review contributions - this has already been fixed (ie. removed)
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
0 tests is considered a failure by TestSwarm. Also there is another expect(2); higher in the function. Is there some context behind this?
Sorry, something went wrong.
The context is that if dimensions isn't built (it's now conditional), then height and width functions are defined.
Thanks, I missed that new feature. Awesome.
I'm not sure I understand this commit. Why does this matter if the whole module is wrapped in this same conditional you've added?
Don't know what to tell you... There were errors, this fixed it. I say we just move on, shall we?
Yeah, I'd love to move on, but this indicates that I can't reliably test locally, because those conditionals weren't necessary locally, nor do they really make any sense, unless I don't know how testswarm works.
@rwldrn was that failing for you locally? I'm not sure why you'd need to have another guard test but maybe it was a caching issue.
Locally, yes. No cache, I test in incognito mode with cache off and double down with cache busted URLs.
I just figured it had something to do with running in an iframe.
Just admit that this commit makes no sense and we can move on :-)
There is a typo, I'll admit that.
We may never know why I saw what I saw, but it is no more. Fresh build -dimensions, no issues now...
@mikesherov The conditional has no relation to testswarm. The issue with testswarm is the expect(0);. If a test should not be run, then conditionally run the test instead of just its assertions. If a test has 0 assertions, it is considered a failure.
@Krinkle have we figured out a way to test optional module builds? The expect(0) code can only be reached if jQuery was built with: grunt build:*:*:-dimensions