Skip to content
Permalink
Browse files

Only change ID on nodes that don't already have an ID for rooted qSA.…

… Fixes #7212.
  • Loading branch information...
jeresig committed Nov 1, 2010
1 parent 9d1bfeb commit 62c83a764cdb3f6e7f6a9b696de1636570df19bf
Showing with 6 additions and 1 deletion.
  1. +6 −1 test/unit/selector.js
@@ -1,7 +1,7 @@
module("selector");

test("element", function() {
expect(18);
expect(21);

This comment has been minimized.

Copy link
@paulirish

paulirish Nov 3, 2010

Member

press me if you like the number 21!

This comment has been minimized.

Copy link
@cowboy

cowboy Nov 3, 2010

Member

Dear sir, I pressed your button just now and nothing happened. Where may I file a bug report?

This comment has been minimized.

Copy link
@cowboy

cowboy Nov 3, 2010

Member

Oops

This comment has been minimized.

Copy link
@ralphholzmann

This comment has been minimized.

Copy link
@paulirish

paulirish Nov 3, 2010

Member

<textarea>i suppose this isn't a bug. must be a feature</textarea>

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Nov 3, 2010

Contributor
<style>body { display: none; }</style>

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Nov 3, 2010

Contributor
<iframe src="http://www.google.com/"></iframe>

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Nov 3, 2010

Contributor
ohai
QUnit.reset();

ok( jQuery("*").size() >= 30, "Select all" );
@@ -32,6 +32,11 @@ test("element", function() {
t( "Checking sort order", "h2, h1", ["qunit-header", "qunit-banner", "qunit-userAgent"] );
t( "Checking sort order", "h2:first, h1:first", ["qunit-header", "qunit-banner"] );
t( "Checking sort order", "p, p a", ["firstp", "simon1", "ap", "google", "groups", "anchor1", "mark", "sndp", "en", "yahoo", "sap", "anchor2", "simon", "first"] );

// Test Conflict ID
same( jQuery("#lengthtest").find("#idTest").get(), q("idTest"), "Finding element with id of ID." );
same( jQuery("#lengthtest").find("[name='id']").get(), q("idTest"), "Finding element with id of ID." );
same( jQuery("#lengthtest").find("input[id='idTest']").get(), q("idTest"), "Finding elements with a context." );
});

if ( location.protocol != "file:" ) {

5 comments on commit 62c83a7

@jzaefferer

This comment has been minimized.

Copy link
Member

replied Nov 1, 2010

How does a test change fix a bug?

@jitter

This comment has been minimized.

Copy link
Contributor

replied Nov 2, 2010

The actual fix happened in the sizzle source.

@bentruyman

This comment has been minimized.

Copy link
Contributor

replied Nov 3, 2010

Marketing is fun

@bentruyman

This comment has been minimized.

Copy link
Contributor

replied Nov 3, 2010

Metrics an science lead to

@bentruyman

This comment has been minimized.

Copy link
Contributor

replied Nov 3, 2010

_Making _big* logos*

Please sign in to comment.
You can’t perform that action at this time.