Skip to content
Permalink
Browse files

When a native browser event is bubbling up the DOM, make sure that th…

…e correct isDefaultPrevented value is reflected by jQuery's Event object. Fixes #7793.
  • Loading branch information...
dmethvin authored and csnover committed Dec 27, 2010
1 parent 6ffa730 commit 64ee5581afd6e9667ad45e75f082c95e2725efa6
Showing with 41 additions and 0 deletions.
  1. +6 −0 src/event.js
  2. +35 −0 test/unit/event.js
@@ -600,6 +600,12 @@ jQuery.Event = function( src ) {
if ( src && src.type ) {
this.originalEvent = src;
this.type = src.type;

// Events bubbling up the document may have been marked as prevented
// by a handler lower down the tree; reflect the correct value.
this.isDefaultPrevented = (src.defaultPrevented || src.returnValue === false ||
src.getPreventDefault && src.getPreventDefault()) ? returnTrue : returnFalse;

This comment has been minimized.

Copy link
@pixeltrix

pixeltrix Feb 23, 2011

This always returns true for mouse enter events in Firefox (3.6 & 4, Mac & PC) - see: http://jsfiddle.net/TC3uE/. If the trigger element is a DIV tag then everything is fine.


// Event type
} else {
this.type = src;
@@ -295,6 +295,41 @@ test("live/delegate immediate propagation", function() {
$p.undelegate( "click" );
});

test("bind/delegate bubbling, isDefaultPrevented (Bug #7793)", function() {
expect(2);
var $anchor2 = jQuery( "#anchor2" ),
$main = jQuery( "#main" ),
fakeClick = function($jq) {
// Use a native click so we don't get jQuery simulated bubbling
if ( document.createEvent ) {
var e = document.createEvent( "MouseEvents" );
e.initEvent( "click", true, true );
$jq[0].dispatchEvent(e);
}
else if ( $jq[0].click ) {
$jq[0].click(); // IE
}
};
$anchor2.click(function(e) {
e.preventDefault();
});
$main.delegate("#foo", "click", function(e) {
equals( e.isDefaultPrevented(), true, "isDefaultPrevented true passed to bubbled event" );
});
fakeClick( $anchor2 );
$anchor2.unbind( "click" );
$main.undelegate( "click" );
$anchor2.click(function(e) {
// Let the default action occur
});
$main.delegate("#foo", "click", function(e) {
equals( e.isDefaultPrevented(), false, "isDefaultPrevented false passed to bubbled event" );
});
fakeClick( $anchor2 );
$anchor2.unbind( "click" );
$main.undelegate( "click" );
});

test("bind(), iframes", function() {
// events don't work with iframes, see #939 - this test fails in IE because of contentDocument
var doc = jQuery("#loadediframe").contents();

0 comments on commit 64ee558

Please sign in to comment.
You can’t perform that action at this time.