Skip to content
Permalink
Browse files

Ref #14313: NaN detection. Close gh-1352.

(cherry picked from commit 0bc0a69)
  • Loading branch information...
gibson042 committed Sep 5, 2013
1 parent 1d57ffe commit 68213f20bb5d5426f99bafde028ecab601a9d105
Showing with 6 additions and 3 deletions.
  1. +4 −1 src/core.js
  2. +2 −2 src/css.js
@@ -221,7 +221,10 @@ jQuery.extend({
},

isNumeric: function( obj ) {
return !isNaN( parseFloat(obj) ) && isFinite( obj );
// parseFloat NaNs numeric-cast false positives (null|true|false|"")
// ...but misinterprets leading-number strings, particularly hex literals ("0x...")
// subtraction forces infinities to NaN
return obj - parseFloat( obj ) >= 0;
},

type: function( obj ) {
@@ -273,8 +273,8 @@ jQuery.extend({
type = "number";
}

// Make sure that NaN and null values aren't set. See: #7116
if ( value == null || type === "number" && isNaN( value ) ) {
// Make sure that null and NaN values aren't set. See: #7116
if ( value == null || value !== value ) {
return;
}

0 comments on commit 68213f2

Please sign in to comment.
You can’t perform that action at this time.