Fix #13401: replaceWith(""). Close gh-1163.

jquery · Feb 8, 2013 · 6a0ee2d · 6a0ee2d
1 parent dc9b009
commit 6a0ee2d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -241,15 +241,17 @@ jQuery.fn.extend({
 			value = jQuery( value ).not( this ).detach();
 		}
 
-		return this.domManip( [ value ], true, function( elem ) {
-			var next = this.nextSibling,
-				parent = this.parentNode;
-
-			if ( parent ) {
-				jQuery( this ).remove();
-				parent.insertBefore( elem, next );
-			}
-		});
+		return value !== "" ?
+			this.domManip( [ value ], true, function( elem ) {
+				var next = this.nextSibling,
+					parent = this.parentNode;
+
+				if ( parent ) {
+					jQuery( this ).remove();
+					parent.insertBefore( elem, next );
+				}
+			}) :
+			this.remove();
 	},
 
 	detach: function( selector ) {

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -1219,6 +1219,15 @@ test( "replaceWith(string) for more than one element", function() {
 	equal(jQuery("#foo p").length, 0, "verify that all the three original element have been replaced");
 });
 
+test( "replaceWith(\"\") (#13401)", 4, function() {
+	expect( 1 );
+
+	var div = jQuery("<div><p></p></div>");
+
+	div.children().replaceWith("");
+	equal( div.html().toLowerCase(), "", "Replacing with empty string removes element" );
+});
+
 test( "replaceAll(String|Element|Array<Element>|jQuery)", function() {
 
 	expect( 10 );