Skip to content
Permalink
Browse files

jQuery.ajax modified the passed-in object only to help test the code …

…- this shouldn't occur. Fixes #5439.
  • Loading branch information
jeresig committed Nov 7, 2009
1 parent 1a94a46 commit 6a722e251dedd5f01ac0c46e330a368be7bb760b
Showing with 6 additions and 1 deletion.
  1. +1 −1 src/ajax.js
  2. +5 −0 test/unit/ajax.js
@@ -194,7 +194,7 @@ jQuery.extend({
ajax: function( s ) {
// Extend the settings, but re-extend 's' so that it can be
// checked again later (in the test suite, specifically)
s = jQuery.extend(true, s, jQuery.extend(true, {}, jQuery.ajaxSettings, s));
s = jQuery.extend(true, {}, jQuery.ajaxSettings, s);

var jsonp, status, data,
callbackContext = s.context || window,
@@ -368,6 +368,10 @@ test("ajax cache", function () {
ok( jQuery.ajax({url: "data/text.php?name=David&_=tobereplaced555&washere=true", cache:false}), "test with 2 parameters surrounding _= one" );
});

/*
* Test disabled.
* The assertions expect that the passed-in object will be modified,
* which shouldn't be the case. Fixes #5439.
test("global ajaxSettings", function() {
expect(2);
@@ -389,6 +393,7 @@ test("global ajaxSettings", function() {
jQuery.ajaxSettings = tmp;
});
*/

test("load(String)", function() {
expect(1);

0 comments on commit 6a722e2

Please sign in to comment.
You can’t perform that action at this time.