Permalink
Show file tree
Hide file tree
4 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
For .show() with no arguments, only set display of elements in the se…
…cond loop if they don't have style.display already set or if style.display isn't none. Fixes #7315.
- Loading branch information
Showing
2 changed files
with
30 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ab402d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted a bug, I guess it's from this commit.
Tried to make the simplest scenario here: http://jsfiddle.net/JYFuV/2/
Using Firefox 3.6.11
6ab402d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's really strange. I see the problem in your linked jsfiddle page, but I can't reproduce it locally in the test suite or in a standalone page with a simple test case: http://test.learningjquery.com/hide-show/
Is my test case doing something obviously different from yours that I'm not seeing?
6ab402d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Karl: I was able to reproduce it in the test suite and fixed it as well, just now:
http://bugs.jquery.com/ticket/7331
6ab402d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Cool deal. Thanks, John!