Rather than declaring empty anonymous functions all around, introduce…

… and use a single empty function. Thanks to Matt Kruse for the suggestion.
jquery · 6cb2945837ccca55204191a8e7a70b2b2486c28e · jeresig committed Dec 31, 2009 · Dec 31, 2009 · 6cb2945 · DBJDBJ
1 parent fe6c86d
commit 6cb2945837ccca55204191a8e7a70b2b2486c28e
Unified Split

Showing with 6 additions and 4 deletions.

+2 −2 src/ajax.js

+2 −0 src/core.js

+1 −1 src/event.js

+1 −1 src/offset.js
diff --git a/src/ajax.js b/src/ajax.js
@@ -384,7 +384,7 @@ jQuery.extend({
 			// The request was aborted, clear the interval and decrement jQuery.active
 			if ( !xhr || xhr.readyState === 0 ) {
 				requestDone = true;
-				xhr.onreadystatechange = function(){};
+				xhr.onreadystatechange = jQuery.noop;
 
 				// Handle the global AJAX counter
 				if ( s.global && ! --jQuery.active ) {
@@ -394,7 +394,7 @@ jQuery.extend({
 			// The transfer is complete and the data is available, or the request timed out
 			} else if ( !requestDone && xhr && (xhr.readyState === 4 || isTimeout === "timeout") ) {
 				requestDone = true;
-				xhr.onreadystatechange = function(){};
+				xhr.onreadystatechange = jQuery.noop;
 
 				status = isTimeout === "timeout" ?
 					"timeout" :
diff --git a/src/core.js b/src/core.js
@@ -464,6 +464,8 @@ jQuery.extend({
 		return true;
 	},
 
+	noop: function() {},
+
 	// Evalulates a script in a global context
 	globalEval: function( data ) {
 		if ( data && rnotwhite.test(data) ) {
diff --git a/src/event.js b/src/event.js
@@ -427,7 +427,7 @@ jQuery.event = {
 		ready: {
 			// Make sure the ready event is setup
 			setup: jQuery.bindReady,
-			teardown: function() {}
+			teardown: jQuery.noop
 		},
 
 		live: {
diff --git a/src/offset.js b/src/offset.js
@@ -121,7 +121,7 @@ jQuery.offset = {
 
 		body.removeChild( container );
 		body = container = innerDiv = checkDiv = table = td = null;
-		jQuery.offset.initialize = function() {};
+		jQuery.offset.initialize = jQuery.noop;
 	},
 
 	bodyOffset: function( body ) {