Calling .hide().show() on a stylesheet-hidden element wasn't bringing…

… it back. Fixes #7331.
jquery · Oct 27, 2010 · 6e7a4e7 · 6e7a4e7
1 parent 6ab402d
commit 6e7a4e7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/effects.js b/src/effects.js
@@ -28,7 +28,7 @@ jQuery.fn.extend({
 				// Reset the inline display of this element to learn if it is
 				// being hidden by cascaded rules or not
 				if ( !jQuery.data(elem, "olddisplay") && display === "none" ) {
-					elem.style.display = "";
+					display = elem.style.display = "";
 				}
 
 				// Set elements which have been overridden with display: none

diff --git a/test/unit/effects.js b/test/unit/effects.js
@@ -6,10 +6,18 @@ test("sanity check", function() {
 });
 
 test("show()", function() {
-	expect(26);
+	expect(27);
 
 	var hiddendiv = jQuery("div.hidden");
 
+	hiddendiv.hide().show();
+
+	equals( hiddendiv.css("display"), "block", "Make sure a pre-hidden div is visible." );
+
+	QUnit.reset();
+
+	hiddendiv = jQuery("div.hidden");
+
 	equal(jQuery.css( hiddendiv[0], "display"), "none", "hiddendiv is display: none");
 
 	hiddendiv.css("display", "block");