Permalink
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fixes a weird IE7 bug in the unit tests. If anybody can shed some lig…
…ht on this one, I'm a taker.
- Loading branch information
Showing
1 changed file
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6eb7567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure that out? Seems awfully strange and might indicate a problem in the Callbacks implementation.
6eb7567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually like to know what "start" does. I don't have any facility to debug under IE6/7 so I may have to defer to someone else on this one.
Also, I seem to remember you saying it started to fail in 1.6.4. Seems to imply something else changed. I mean, Deferred and Callbacks are heavily tested in the unit tests with and without custom context so I find it a bit strange the only time it fails is when qunit's start is called with the Deferred as its context.
6eb7567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were no ajax fails in 1.6.4 in IE6 or 7, but reverting back to 1.6.4 and testing with the new QUnit does give us an error. If I had more time, I would look into the QUnit changes.
6eb7567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah DUH! We updated QUnit and I bet that has something to do with it since
start()
is one of the things for async testing. Exactly why it is failing I don't know but it most likely points to a change in QUnit.6eb7567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, same time dave