Skip to content
Permalink
Browse files
Fixes a weird IE7 bug in the unit tests. If anybody can shed some lig…
…ht on this one, I'm a taker.
  • Loading branch information
jaubourg committed Sep 22, 2011
1 parent d638aa9 commit 6eb75676c4d21550daa755c3dfc3539b1c530556
Showing 1 changed file with 6 additions and 1 deletion.
@@ -1760,7 +1760,12 @@ test("jQuery.post - data", 3, function() {
strictEqual( data, "test%5Blength%5D=7&test%5Bfoo%5D=bar", "Check if a sub-object with a length param is serialized correctly");
}
})
).then( start, start );
// The more compact then( start, start ) doesn't work in IE7
).then( function() {
start();
}, function() {
start();
} );

});

5 comments on commit 6eb7567

@dmethvin
Copy link
Member

@dmethvin dmethvin commented on 6eb7567 Sep 23, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure that out? Seems awfully strange and might indicate a problem in the Callbacks implementation.

@jaubourg
Copy link
Member Author

@jaubourg jaubourg commented on 6eb7567 Sep 23, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually like to know what "start" does. I don't have any facility to debug under IE6/7 so I may have to defer to someone else on this one.

Also, I seem to remember you saying it started to fail in 1.6.4. Seems to imply something else changed. I mean, Deferred and Callbacks are heavily tested in the unit tests with and without custom context so I find it a bit strange the only time it fails is when qunit's start is called with the Deferred as its context.

@timmywil
Copy link
Member

@timmywil timmywil commented on 6eb7567 Sep 23, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no ajax fails in 1.6.4 in IE6 or 7, but reverting back to 1.6.4 and testing with the new QUnit does give us an error. If I had more time, I would look into the QUnit changes.

@dmethvin
Copy link
Member

@dmethvin dmethvin commented on 6eb7567 Sep 23, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah DUH! We updated QUnit and I bet that has something to do with it since start() is one of the things for async testing. Exactly why it is failing I don't know but it most likely points to a change in QUnit.

@timmywil
Copy link
Member

@timmywil timmywil commented on 6eb7567 Sep 23, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, same time dave

Please sign in to comment.