Skip to content
Permalink
Browse files

Added support for sorting in Safari - when querySelectorAll isn't abl…

…e to be used.
  • Loading branch information
jeresig committed Feb 14, 2009
1 parent d75c899 commit 6f4b08cdf9cb334f8531fe06a20153defb7f95b6
Showing with 17 additions and 3 deletions.
  1. +4 −2 src/core.js
  2. +11 −0 src/selector.js
  3. +2 −1 test/unit/selector.js
@@ -75,7 +75,9 @@ jQuery.fn = jQuery.prototype = {
this.context = selector.context;
}

return this.setArray(jQuery.makeArray(selector));
return this.setArray(jQuery.isArray( selector ) ?
selector :
jQuery.makeArray(selector));
},

// Start with an empty selector
@@ -95,7 +97,7 @@ jQuery.fn = jQuery.prototype = {
return num === undefined ?

// Return a 'clean' array
jQuery.makeArray( this ) :
Array.prototype.slice.call( this ) :

// Return just the object
this[ num ];
@@ -679,6 +679,17 @@ if ( document.documentElement.compareDocumentPosition ) {
}
return ret;
};
} else if ( Array.prototype.indexOf ) {
var indexOf = Array.prototype.indexOf,
allSort = document.getElementsByTagName("*");

sortOrder = function( a, b ) {
var ret = indexOf.call( allSort, a ) - indexOf.call( allSort, b );
if ( ret === 0 ) {
hasDuplicate = true;
}
return ret;
};
}

// Check to see if the browser returns elements by name when
@@ -1,7 +1,7 @@
module("selector");

test("element", function() {
expect(13);
expect(14);
reset();

ok( jQuery("*").size() >= 30, "Select all" );
@@ -24,6 +24,7 @@ test("element", function() {
isSet( jQuery("p"), jQuery("p, div p"), "Check for duplicates: p, div p" );

t( "Checking sort order", "h2, h1", ["header", "banner", "userAgent"] );
t( "Checking sort order", "h2:first, h1:first", ["header", "banner"] );
t( "Checking sort order", "p, p a", ["firstp", "simon1", "ap", "google", "groups", "anchor1", "mark", "sndp", "en", "yahoo", "sap", "anchor2", "simon", "first"] );
});

0 comments on commit 6f4b08c

Please sign in to comment.
You can’t perform that action at this time.