Skip to content
Permalink
Browse files

Update Sizzle: Add test for [selected] attribute selections. Addresse…

…s a small issue in IE8's boolean attribute selections with QSA.
  • Loading branch information
timmywil committed May 28, 2012
1 parent 631f093 commit 6f7bdf8977e2eb9e6f528218ea5c99653a224c35
Showing with 4 additions and 4 deletions.
  1. +1 −1 src/sizzle
  2. +3 −3 test/unit/selector.js
Submodule sizzle updated 1 files
+67 −57 sizzle.js
@@ -62,7 +62,7 @@ test("disconnected nodes", function() {
});

testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQuery, window, document ) {
expect(34);
expect(35);

/**
* Returns an array of elements with the given IDs, eg.
@@ -119,7 +119,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue
t( "Attribute Exists", "[indeterminate]", []);
t( "Attribute Exists", "[ismap]", ["img1"]);
t( "Attribute Exists", "[itemscope]", ["div1"]);
// t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately only retrieves the property value.
// t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately also retrieves the property value.
t( "Attribute Exists", "[multiple]", ["select1"]);
t( "Attribute Exists", "[muted]", ["audio1"]);
// t( "Attribute Exists", "[nohref]", ["area1"]); // IE 6/7 keep this set to false regardless of presence. The attribute node is not retrievable.
@@ -134,7 +134,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue
t( "Attribute Exists", "[reversed]", ["ol1"]);
t( "Attribute Exists", "[scoped]", ["style1"]);
t( "Attribute Exists", "[seamless]", ["iframe1"]);
// t( "Attribute Exists", "[selected]", ["option1"]); // IE8's querySelectorAll fails here. Redirecting to oldSizzle would work, but it would require an additional support test as well as a check for the selected attribute within the qsa logic
t( "Attribute Exists", "[selected]", ["option1"]);
t( "Attribute Exists", "[truespeed]", ["marquee1"]);

// Enumerated attributes (these are not boolean content attributes)

0 comments on commit 6f7bdf8

Please sign in to comment.
You can’t perform that action at this time.