Skip to content
Permalink
Browse files

Added a fix, and tests, for appending empty sets of elements/strings.

  • Loading branch information
jeresig committed Jan 14, 2007
1 parent e50a2f6 commit 729396e6cfb1a0495399609f5929fb630a49649d
Showing with 13 additions and 1 deletion.
  1. +10 −1 src/jquery/coreTest.js
  2. +3 −0 src/jquery/jquery.js
@@ -192,7 +192,7 @@ test("wrap(String|Element)", function() {
});

test("append(String|Element|Array<Element>|jQuery)", function() {
expect(5);
expect(9);
var defaultText = 'Try them out:'
var result = $('#first').append('<b>buga</b>');
ok( result.text() == defaultText + 'buga', 'Check if text appending works' );
@@ -212,6 +212,15 @@ test("append(String|Element|Array&lt;Element&gt;|jQuery)", function() {
expected = "This link has class=\"blog\": Simon Willison's WeblogTry them out:Yahoo";
$('#sap').append($("#first, #yahoo"));
ok( expected == $('#sap').text(), "Check for appending of jQuery object" );

reset();
$("#sap").append( 5 );
ok( $("#sap")[0].innerHTML.match( /5$/ ), "Check for appending a number" );

reset();
ok( $("#sap").append([]), "Check for appending an empty array." );
ok( $("#sap").append(""), "Check for appending an empty string." );
ok( $("#sap").append(document.getElementsByTagName("foo")), "Check for appending an empty nodelist." );
});

test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
@@ -1443,6 +1443,9 @@ jQuery.extend({

arg = div.childNodes;
}

if ( arg.length === 0 )
continue;

if ( arg[0] == undefined )
r.push( arg );

0 comments on commit 729396e

Please sign in to comment.
You can’t perform that action at this time.