Skip to content
Permalink
Browse files

Fix in logic for handling exclusive namespace testing. Fixes #6048.

  • Loading branch information
jeresig committed Feb 8, 2010
1 parent d743899 commit 75bb2d6e510a3c048a42ce673e9655fa779eacd5
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/event.js
@@ -362,7 +362,7 @@ jQuery.event = {
event.currentTarget = this;

// Namespaced event handlers
all = event.type.indexOf(".") < 0;
all = event.type.indexOf(".") < 0 && !event.exclusive;

if ( !all ) {
namespaces = event.type.split(".");
@@ -380,7 +380,7 @@ jQuery.event = {
var handleObj = handlers[ j ];

// Filter the functions by class
if ( (all && !event.exclusive) || namespace.test( handleObj.namespace ) ) {
if ( all || namespace.test( handleObj.namespace ) ) {
// Pass in a reference to the handler function itself
// So that we can later remove it
event.handler = handleObj.handler;

4 comments on commit 75bb2d6

@irae

This comment has been minimized.

Copy link
Contributor

irae replied Feb 9, 2010

xD

This was a good one! I've spent about 40 minutes trying to solve this issue as a bug (before posting the issue in trac).
Turns out it was a test case problem.

John, isn't a bit dangerous changing a test that passed in previous releases?

@jeresig

This comment has been minimized.

Copy link
Member Author

jeresig replied Feb 9, 2010

@irae: I see that your posts aren't coming through. You should file a Github support ticket, sometimes people get put in the spam filter accidentally and need to be freed.

@jeresig

This comment has been minimized.

Copy link
Member Author

jeresig replied Feb 9, 2010

@irae: I'm not sure what you're referring to with regards to the changing of tests - can you expand on that?

@irae

This comment has been minimized.

Copy link
Contributor

irae replied Feb 9, 2010

Nevermind!
My bad! I've misread the commit message.

I've missed the src/event.js filename and I was under the impression that you've changed test/unit/event.js
Sorry about that! =)

Please sign in to comment.
You can’t perform that action at this time.