Permalink
Browse files

Build: account for version labels in Sizzle versions

Fixes gh-1939
  • Loading branch information...
timmywil committed Dec 17, 2014
1 parent 03557db commit 78ac753192d5490295a46b60f278c030d958bf6d
Showing with 1 addition and 1 deletion.
  1. +1 −1 build/ensure-sizzle.js
View
@@ -1,7 +1,7 @@
var fs = require( "fs" ),
npm = require( "npm" ),
sizzleLoc = __dirname + "/../external/sizzle/dist/sizzle.js",
rversion = /Engine v(\d+\.\d+\.\d+(?:-\w+)?)/;
rversion = /Engine v(\d+\.\d+\.\d+[-\.\d\w]*)/;

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Dec 17, 2014

Member

The part after patch-level \d+ should be something like (?:-[-\.\w]+)? (if present, must start with a "-").

@gibson042

gibson042 Dec 17, 2014

Member

The part after patch-level \d+ should be something like (?:-[-\.\w]+)? (if present, must start with a "-").

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Dec 17, 2014

Member

I was a accounting for dashes in labels too, but maybe that's invalid.

@timmywil

timmywil Dec 17, 2014

Member

I was a accounting for dashes in labels too, but maybe that's invalid.

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Dec 17, 2014

Member

Like 2.1.1-jquery-compat.2.1.2

@timmywil

timmywil Dec 17, 2014

Member

Like 2.1.1-jquery-compat.2.1.2

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Dec 17, 2014

Member

Ah, yours does to. Yea, that's better.

@timmywil

timmywil Dec 17, 2014

Member

Ah, yours does to. Yea, that's better.

require( "colors" );

0 comments on commit 78ac753

Please sign in to comment.