Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Edited comments and minor adjustments. Fixes #13553. Closes gh-1195.

  • Loading branch information...
commit 79992d752393d80822a4f8be2b7bec3ecdd60f6a 1 parent ae35246
Michał Gołębiowski mzgol authored timmywil committed
1  AUTHORS.txt
View
@@ -163,3 +163,4 @@ Adam Coulombe <me@adam.co>
Andrew Plummer <plummer.andrew@gmail.com>
Nguyen Phuc Lam <ruado1987@gmail.com>
Dmitry Gusev <dmitry.gusev@gmail.com>
+Michał Z. Gołębiowski <michal.golebiowski@laboratorium.ee>
2  build/release.js
View
@@ -181,7 +181,7 @@ function uploadToCDN( next ) {
});
});
cmds.push( next );
-
+
steps.apply( this, cmds );
}
2  speed/benchmark.js
View
@@ -4,7 +4,7 @@ function benchmark(fn, times, name){
var s = fn.indexOf('{')+1,
e = fn.lastIndexOf('}');
fn = fn.substring(s,e);
-
+
return benchmarkString(fn, times, name);
}
2  speed/event.html
View
@@ -8,7 +8,7 @@
<script src="../dist/jquery.js"></script>
<script>
jQuery(function(){
-
+
});
var events = [], num = 400, exec = false;
26 speed/slice.vs.concat.html
View
@@ -6,42 +6,42 @@
var SIZE = 1e4,
LOOPS = 500;
-
+
var arr = new Array(SIZE);
- for ( var i=arr.length-1; i >= 0; --i )
+ for ( var i = arr.length - 1; i >= 0; --i )
arr[i] = 0;
var t = new Date;
- for ( i=0; i < LOOPS; i++ )
+ for ( i = 0; i < LOOPS; i++ )
arr.slice(0);
var tslice = new Date - t;
-
+
t = new Date;
- for ( i=0; i < LOOPS; i++ )
+ for ( i = 0; i < LOOPS; i++ )
arr.concat();
var tconcat = new Date - t;
-
+
// clone() is just to see how fast built-ins are
t = new Date;
- for ( i=0; i < LOOPS; i++ )
+ for ( i = 0; i < LOOPS; i++ )
clone(arr);
var tclone = new Date - t;
-
+
alert([
'slice:'+tslice,
'concat:'+tconcat,
'clone:'+tclone
].join('\n'));
-
-
+
+
function clone(arr){
var i = arr.length,
copy = new Array(i);
-
+
while (i--)
copy[i] = arr[i];
-
+
return copy;
}
})();
-</script>
+</script>
9 src/ajax.js
View
@@ -2,7 +2,7 @@ var
// Document location
ajaxLocParts,
ajaxLocation,
-
+
ajax_nonce = jQuery.now(),
ajax_rquery = /\?/,
@@ -140,7 +140,7 @@ jQuery.fn.load = function( url, params, callback ) {
off = url.indexOf(" ");
if ( off >= 0 ) {
- selector = url.slice( off, url.length );
Markus Staab
staabm added a note

just curious: all changes were whitespace related except this one... was it changed intentionally?

Markus Staab
staabm added a note

sorry for commenting such an old commit, don't know why github made it show up in my notifications..

Michał Gołębiowski Collaborator
mzgol added a note

Not whitespace-only, comments were also edited. And this one was just not needed.

Today I wouldn't do all that in a single commit, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ selector = url.slice( off );
url = url.slice( 0, off );
}
@@ -427,10 +427,11 @@ jQuery.extend({
jqXHR.error = jqXHR.fail;
// Remove hash character (#7531: and string promotion)
- // Add protocol if not provided (#5866: IE7 issue with protocol-less urls)
+ // Add protocol if not provided (prefilters might expect it)
// Handle falsy url in the settings object (#10093: consistency with old signature)
// We also use the url parameter if available
- s.url = ( ( url || s.url || ajaxLocation ) + "" ).replace( rhash, "" ).replace( rprotocol, ajaxLocParts[ 1 ] + "//" );
+ s.url = ( ( url || s.url || ajaxLocation ) + "" ).replace( rhash, "" )
+ .replace( rprotocol, ajaxLocParts[ 1 ] + "//" );
// Alias method option to type as per ticket #12004
s.type = options.method || options.type || s.method || s.type;
4 src/dimensions.js
View
@@ -20,8 +20,8 @@ jQuery.each( { Height: "height", Width: "width" }, function( name, type ) {
if ( elem.nodeType === 9 ) {
doc = elem.documentElement;
- // Either scroll[Width/Height] or offset[Width/Height] or client[Width/Height], whichever is greatest
- // unfortunately, this causes bug #3838 in IE6/8 only, but there is currently no good, small way to fix it.
+ // Either scroll[Width/Height] or offset[Width/Height] or client[Width/Height],
+ // whichever is greatest
return Math.max(
elem.body[ "scroll" + name ], doc[ "scroll" + name ],
elem.body[ "offset" + name ], doc[ "offset" + name ],
4 src/effects.js
View
@@ -440,8 +440,8 @@ Tween.propHooks = {
}
};
-// Remove in 2.0 - this supports IE8's panic based approach
-// to setting things on disconnected nodes
+// Support: IE9
+// Panic based approach to setting things on disconnected nodes
Tween.propHooks.scrollTop = Tween.propHooks.scrollLeft = {
set: function( tween ) {
2  src/event.js
View
@@ -66,7 +66,7 @@ jQuery.event = {
tmp = rtypenamespace.exec( types[t] ) || [];
type = origType = tmp[1];
namespaces = ( tmp[2] || "" ).split( "." ).sort();
-
+
// There *must* be a type, no attaching namespace-only handlers
if ( !type ) {
continue;
2  test/unit/ajax.js
View
@@ -1468,7 +1468,7 @@ module( "ajax", {
strictEqual( ajaxXML.find("tab").length, 3, "Parsed node was added properly" );
}
});
-
+
ajaxTest( "#13292 - jQuery.ajax() - converter is bypassed for 204 requests", 3, {
url: "data/nocontent.php",
dataType: "testing",
2  test/unit/attributes.js
View
@@ -446,7 +446,7 @@ test( "attr(String, Object)", function() {
// Setting attributes on svg elements (bug #3116)
var $svg = jQuery(
- "<svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' version='1.1' baseProfile='full' width='200' height='200'>" +
+ "<svg xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink' version='1.1' baseProfile='full' width='200' height='200'>" +
"<circle cx='200' cy='200' r='150' />" +
"</svg>"
Markus Staab

just curious: all changes were whitespace related except this one... was it changed intentionally?

Markus Staab

sorry for commenting such an old commit, don't know why github made it show up in my notifications..

Michał Gołębiowski
Collaborator

Not whitespace-only, comments were also edited. And this one was just not needed.

Today I wouldn't do all that in a single commit, though.

Please sign in to comment.
Something went wrong with that request. Please try again.