Skip to content
Permalink
Browse files

We only support wrapping the first element around an element (all oth…

…ers are ignored). Fixes ticket #4903.
  • Loading branch information
jeresig committed Jul 14, 2009
1 parent 991dafa commit 7a04d1da54caec00b900620390df820fb85b1227
Showing with 8 additions and 2 deletions.
  1. +1 −1 src/manipulation.js
  2. +7 −1 test/unit/manipulation.js
@@ -24,7 +24,7 @@ jQuery.fn.extend({

if ( this[0] ) {
// The elements to wrap the target around
var wrap = jQuery( html, this[0].ownerDocument ).clone();
var wrap = jQuery( html, this[0].ownerDocument ).eq(0).clone();

if ( this[0].parentNode )
wrap.insertBefore( this[0] );
@@ -10,7 +10,7 @@ test("text()", function() {
});

var testWrap = function(val) {
expect(12);
expect(15);
var defaultText = 'Try them out:'
var result = jQuery('#first').wrap(val( '<div class="red"><span></span></div>' )).text();
equals( defaultText, result, 'Check for wrapping of on-the-fly html' );
@@ -45,6 +45,12 @@ var testWrap = function(val) {
j = jQuery("<span/>").wrap("<div>test</div>");
equals( j[0].previousSibling.nodeType, 3, "Make sure the previous node is a text element" );
equals( j[0].parentNode.nodeName.toUpperCase(), "DIV", "And that we're in the div element." );

// Try to wrap an element with multiple elements (should fail)
j = jQuery("<div><span></span></div>").children().wrap("<p></p><div></div>");
equals( j[0].parentNode.parentNode.childNodes.length, 1, "There should only be one element wrapping." );
equals( j.length, 1, "There should only be one element (no cloning)." );
equals( j[0].parentNode.nodeName.toUpperCase(), "P", "The span should be in the paragraph." );
}

test("wrap(String|Element)", function() {

0 comments on commit 7a04d1d

Please sign in to comment.
You can’t perform that action at this time.