Skip to content
Permalink
Browse files
browser version detection revised for opera >= 10, which was reportin… 
…g itself as 9.8 due to their new policy
  • Loading branch information
@paulirish @jeresig
paulirish authored and jeresig committed Jan 12, 2010
1 parent f14fade commit 7be5ec1248c749ece648c8d80a71b45320556381
Showing 1 changed file with 2 additions and 2 deletions.
4 src/core.js
View file
@@ -661,8 +661,8 @@ jQuery.extend({
ret = { browser: "webkit", version: /webkit[\/ ]([\w.]+)/ };

} else if ( /opera/.test( ua ) ) {
ret = { browser: "opera", version: /opera[\/ ]([\w.]+)/ };

ret = { browser: "opera", version: /version/.test( ua ) ? /version[\/ ]([\w.]+)/ : /opera[\/ ]([\w.]+)/ };
} else if ( /msie/.test( ua ) ) {
ret = { browser: "msie", version: /msie ([\w.]+)/ };

3 comments on commit 7be5ec1

@paulirish
Copy link
Member Author

@paulirish paulirish commented on 7be5ec1 Jan 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

details on this 9.80 thing: http://dev.opera.com/articles/view/opera-ua-string-changes/

i went with this regex approach mostly for consistency..

the alternative is using window.opera.version(), which is supported in opera 7.6+, though we wouldnt have the useragent unit tests against it, obviously.

} else if (/Opera/.test({}.toString.call(window.opera)))
  ret = { browser: "opera", version: opera.version() };

@jdalton
Copy link
Member

@jdalton jdalton commented on 7be5ec1 Jan 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you went with the more brittle solution ?
Opera has proven that it doesn't mind changing the UA string so why rely on it when the alternative smaller/more reliable solution exists ?
Consistency can take a back seat here. A toString variable already exists in your primary closure so no need to use {}.

@cowboy
Copy link
Member

@cowboy cowboy commented on 7be5ec1 Jan 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were using a RegExp, I'd do something more like..

} else if ( matches = /^(opera).*(?:version)?/(\d+.\d+)/.exec( ua ) ) {
ret = { browser: matches[1], version: matches[2] }
}

Please sign in to comment.