Skip to content
Permalink
Browse files

Broke out the logic for the bubbling change/submit events so that the…

…y aren't bound if they aren't used.
  • Loading branch information
jeresig committed Dec 7, 2009
1 parent 542099a commit 7d36ccfa8eb018fcf349e1f74e3a0a614385558f
Showing with 11 additions and 12 deletions.
  1. +11 −12 src/event.js
@@ -569,9 +569,11 @@ jQuery.each({
});

// submit delegation
if ( !jQuery.support.submitBubbles ) {

jQuery.event.special.submit = {
setup: function( data, namespaces, fn ) {
if ( !jQuery.support.submitBubbles && this.nodeName.toLowerCase() !== "form" ) {
if ( this.nodeName.toLowerCase() !== "form" ) {
jQuery.event.add(this, "click.specialSubmit." + fn.guid, function( e ) {
var elem = e.target, type = elem.type;

@@ -588,8 +590,6 @@ jQuery.event.special.submit = {
}
});
}

return false;
},

remove: function( namespaces, fn ) {
@@ -598,7 +598,11 @@ jQuery.event.special.submit = {
}
};

}

// change delegation, happens here so we have bind.
if ( !jQuery.support.changeBubbles ) {

jQuery.event.special.change = {
filters: {
click: function( e ) {
@@ -647,21 +651,16 @@ jQuery.event.special.change = {
}
},
setup: function( data, namespaces, fn ) {
// return false if we bubble
if ( !jQuery.support.changeBubbles ) {
for ( var type in changeFilters ) {
jQuery.event.add( this, type + ".specialChange." + fn.guid, changeFilters[type] );
}
for ( var type in changeFilters ) {
jQuery.event.add( this, type + ".specialChange." + fn.guid, changeFilters[type] );
}

// always want to listen for change for trigger
return false;
},
remove: function( namespaces, fn ) {
if ( !jQuery.support.changeBubbles ) {
for ( var type in changeFilters ) {
jQuery.event.remove( this, type + ".specialChange" + (fn ? "."+fn.guid : ""), changeFilters[type] );
}
for ( var type in changeFilters ) {
jQuery.event.remove( this, type + ".specialChange" + (fn ? "."+fn.guid : ""), changeFilters[type] );
}
}
};

2 comments on commit 7d36ccf

@jaubourg

This comment has been minimized.

Copy link
Member

@jaubourg jaubourg replied Dec 7, 2009

There is a missing '}' somewhere and support module should be put before event module in build files now.

@jeresig

This comment has been minimized.

Copy link
Member Author

@jeresig jeresig replied Dec 7, 2009

Fixed in: 97323d1.

Please sign in to comment.
You can’t perform that action at this time.