Skip to content
Permalink
Browse files

Update grunt-bowercopy to 0.5.0

  • Loading branch information
timmywil committed Dec 31, 2013
1 parent e1a4329 commit 7d758aca355522f814aaa91e8199942b1f0d2e6c
Showing with 1 addition and 1 deletion.
  1. +1 −1 package.json
@@ -43,7 +43,7 @@
"grunt-contrib-uglify": "0.2.7",
"grunt-contrib-watch": "0.5.3",

"grunt-bowercopy": "0.4.1",
"grunt-bowercopy": "0.5.0",
"grunt-compare-size": "0.4.0",
"grunt-git-authors": "1.2.0",
"grunt-jscs-checker": "0.2.6",

8 comments on commit 7d758ac

@markelog

This comment has been minimized.

Copy link
Member

markelog replied Jan 3, 2014

You forgot to add component name in front of the commit message

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Jan 3, 2014

No, I the omission was intentional. This isn't firmly related to any of our components.

@mgol

This comment has been minimized.

Copy link
Member

mgol replied Jan 3, 2014

@timmywil It is, to "Build". Every commit has to have an associated component according to the new policy.

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Jan 3, 2014

It is related to Sizzle and Testing more than Build. Like I said, this is not a firm match for any component. And I don't think we need to be legalists here. Let's add component names where they helpfully provide scope for the commit.

@markelog

This comment has been minimized.

Copy link
Member

markelog replied Jan 3, 2014

@timmywil i think it would better if we would document this kind of exception

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez replied Jan 3, 2014

Everything Grunt related is definitely Build. You won't be able to make exceptions like this once we start programmatically checking commit message format, so you might as well get used to it now.

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Jan 3, 2014

There is no "definite" about this. There is a reason why Grunt is now called a task manager rather than just a build tool. This seems like a case where strict adherence to guidelines has steered us away from what is suitable and helpful, but I concede that this is the exception rather than commonplace. That said, I'm all in favor of automating consistency enforcement. This is just the sacrifice that we make.

@mgol

This comment has been minimized.

Copy link
Member

mgol replied Jan 3, 2014

Maybe it's just a question of renaming the "Build" component to sth more suitable.

Please sign in to comment.
You can’t perform that action at this time.