Permalink
8 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add component name in front of the commit message
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I the omission was intentional. This isn't firmly related to any of our components.
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timmywil It is, to "Build". Every commit has to have an associated component according to the new policy.
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is related to Sizzle and Testing more than Build. Like I said, this is not a firm match for any component. And I don't think we need to be legalists here. Let's add component names where they helpfully provide scope for the commit.
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timmywil i think it would better if we would document this kind of exception
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything Grunt related is definitely Build. You won't be able to make exceptions like this once we start programmatically checking commit message format, so you might as well get used to it now.
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "definite" about this. There is a reason why Grunt is now called a task manager rather than just a build tool. This seems like a case where strict adherence to guidelines has steered us away from what is suitable and helpful, but I concede that this is the exception rather than commonplace. That said, I'm all in favor of automating consistency enforcement. This is just the sacrifice that we make.
7d758acThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just a question of renaming the "Build" component to sth more suitable.