Skip to content
Permalink
Browse files
Don't expose jQuery.deletedIds. Close gh-889.
  • Loading branch information
rwaldron authored and dmethvin committed Oct 21, 2012
1 parent 2b0e720 commit 8076a33bd86d15b80992602f4cd662ef741fd803
Showing 3 changed files with 5 additions and 2 deletions.
@@ -36,6 +36,9 @@ var
// Used for detecting and trimming whitespace
core_rnotwhite = /\S/,
core_rspace = /\s+/,

// List of deleted data cache ids, so we can reuse them
core_deletedIds = [],

// Make sure we trim BOM and NBSP (here's looking at you, Safari 5.0 and IE)
rtrim = /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g,
@@ -32,7 +32,7 @@ function internalData( elem, name, data, pvt /* Internal Use Only */ ){
// Only DOM nodes need a new unique ID for each element since their data
// ends up in the global cache
if ( isNode ) {
elem[ internalKey ] = id = jQuery.deletedIds.pop() || jQuery.guid++;
elem[ internalKey ] = id = core_deletedIds.pop() || jQuery.guid++;
} else {
id = internalKey;
}
@@ -829,7 +829,7 @@ jQuery.extend({
elem[ internalKey ] = null;
}

jQuery.deletedIds.push( id );
core_deletedIds.push( id );
}
}
}

1 comment on commit 8076a33

@gibson042
Copy link
Member

@gibson042 gibson042 commented on 8076a33 Oct 21, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well remove the definitions of jQuery.deletedIds and jQuery.uuid while you're in there. 1.9 approaches!

Please sign in to comment.