Make sure that no extra whitespace is leftover after an addClass. Fix…

…es #6050.
jquery · Feb 13, 2010 · 83a044f1b5a733dc7ea76dbc9b7dd3a3dc4b7f25 · 83a044f · leeoniya · Feb 13, 2010
1 parent 94d925c
commit 83a044f1b5a733dc7ea76dbc9b7dd3a3dc4b7f25
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/attributes.js b/src/attributes.js
@@ -43,7 +43,7 @@ jQuery.fn.extend({
 						var className = " " + elem.className + " ";
 						for ( var c = 0, cl = classNames.length; c < cl; c++ ) {
 							if ( className.indexOf( " " + classNames[c] + " " ) < 0 ) {
-								elem.className += " " + classNames[c];
+								elem.className = jQuery.trim( elem.className + " " + classNames[c] );
 							}
 						}
 					}

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -435,7 +435,7 @@ test("val(Function) with incoming value", function() {
 });
 
 var testAddClass = function(valueObj) {
-	expect(2);
+	expect(4);
 	var div = jQuery("div");
 	div.addClass( valueObj("test") );
 	var pass = true;
@@ -448,6 +448,15 @@ var testAddClass = function(valueObj) {
 	var j = jQuery("#nonnodes").contents();
 	j.addClass( valueObj("asdf") );
 	ok( j.hasClass("asdf"), "Check node,textnode,comment for addClass" );
+
+	div = jQuery("<div/>");
+
+	div.addClass( valueObj("test") );
+	equals( div.attr("class"), "test", "Make sure there's no extra whitespace." );
+
+	div.attr("class", " foo");
+	div.addClass( valueObj("test") );
+	equals( div.attr("class"), "foo test", "Make sure there's no extra whitespace." );
 };
 
 test("addClass(String)", function() {