Skip to content
Permalink
Browse files

Manipulation: Change support test to be WWA-friendly

Setting the innerHTML property in an unsafe manner raises issues in
Windows Web Applications. Strings being passed into innerHTML cannot
include the name attribute.

Closes gh-1537
  • Loading branch information
jonathansampson authored and dmethvin committed Mar 11, 2014
1 parent 541e734 commit 85af4e6412e49c2e6a872feef00718a46c2fa2ce
Showing with 9 additions and 2 deletions.
  1. +9 −2 src/manipulation/support.js
@@ -4,10 +4,17 @@ define([

(function() {
var fragment = document.createDocumentFragment(),
div = fragment.appendChild( document.createElement( "div" ) );
div = fragment.appendChild( document.createElement( "div" ) ),
input = document.createElement( "input" );

// #11217 - WebKit loses check when the name is after the checked attribute
div.innerHTML = "<input type='radio' checked='checked' name='t'/>";
// Support: Windows Web Apps (WWA)
// `name` and `type` need .setAttribute for WWA
input.setAttribute( "type", "radio" );
input.setAttribute( "checked", "checked" );
input.setAttribute( "name", "t" );

div.appendChild( input );

// Support: Safari 5.1, iOS 5.1, Android 4.x, Android 2.3
// old WebKit doesn't clone checked state correctly in fragments

0 comments on commit 85af4e6

Please sign in to comment.
You can’t perform that action at this time.