Skip to content
Permalink
Browse files

Change check for skipping the initial quickExpr RegExp check. Fixes #…

…8984.
  • Loading branch information...
jeresig committed May 2, 2011
1 parent f1392d8 commit 86aa764f0b7b659fbd8eec9333d22c3a79bdfcd5
Showing with 15 additions and 3 deletions.
  1. +3 −2 src/core.js
  2. +12 −1 test/unit/core.js
@@ -96,9 +96,10 @@ jQuery.fn = jQuery.prototype = {
// Handle HTML strings
if ( typeof selector === "string" ) {
// Are we dealing with HTML string or an ID?
if ( selector.length > 1024 ) {
// Assume very large strings are HTML and skip the regex check
if ( selector.charAt(0) === "<" || selector.charAt( selector.length - 1 ) === ">" ) {
// Assume that strings that start and end with <> are HTML and skip the regex check
match = [ null, selector, null ];

} else {
match = quickExpr.exec( selector );
}
@@ -12,7 +12,7 @@ test("Basic requirements", function() {
});

test("jQuery()", function() {
expect(25);
expect(29);

// Basic constructor's behavior

@@ -96,6 +96,17 @@ test("jQuery()", function() {

// manually clean up detached elements
elem.remove();

equals( jQuery(" <div/> ").length, 1, "Make sure whitespace is trimmed." );
equals( jQuery(" a<div/>b ").length, 1, "Make sure whitespace and other characters are trimmed." );

var long = "";
for ( var i = 0; i < 128; i++ ) {
long += "12345678";
}

equals( jQuery(" <div>" + long + "</div> ").length, 1, "Make sure whitespace is trimmed on long strings." );
equals( jQuery(" a<div>" + long + "</div>b ").length, 1, "Make sure whitespace and other characters are trimmed on long strings." );
});

test("selector state", function() {

0 comments on commit 86aa764

Please sign in to comment.
You can’t perform that action at this time.