Permalink
Browse files

Make sure that the correct args are passed in to the filter callback …

…(and by extension, the not callback). Fixes #5594.
  • Loading branch information...
1 parent a5f8a14 commit 88572ee6924c2322c9d405280b493c4a894f14e2 @jeresig jeresig committed Dec 10, 2009
Showing with 4 additions and 2 deletions.
  1. +1 −1 src/traversing.js
  2. +3 −1 test/unit/traversing.js
View
@@ -8,7 +8,7 @@ var runtil = /Until$/,
var winnow = function( elements, qualifier, keep ) {
if ( jQuery.isFunction( qualifier ) ) {
return jQuery.grep(elements, function(elem, i) {
- return !!qualifier.call( elem, i ) === keep;
+ return !!qualifier.call( elem, i, elem ) === keep;
});
} else if ( qualifier.nodeType ) {
View
@@ -64,9 +64,11 @@ test("filter(Selector)", function() {
});
test("filter(Function)", function() {
- expect(1);
+ expect(2);
same( jQuery("p").filter(function() { return !jQuery("a", this).length }).get(), q("sndp", "first"), "filter(Function)" );
+
+ same( jQuery("p").filter(function(i, elem) { return !jQuery("a", elem).length }).get(), q("sndp", "first"), "filter(Function) using arg" );
});
test("filter(Element)", function() {

0 comments on commit 88572ee

Please sign in to comment.