Skip to content
Permalink
Browse files

Fix #11382. #11764. Only prevent click events on disabled elements.

We don't want a disabled link/button to register delegated clicks, but we do want events like mouseover or custom events.

This is a compromise, there is no perfect solution. Well, the browsers could be consistent about direct vs. delegated events but *that's* not gonna happen.
  • Loading branch information
dmethvin committed Jun 27, 2012
1 parent 94e744a commit 8a01c9201abb3a5311d5b0019b0322de89df6374
Showing with 16 additions and 7 deletions.
  1. +2 −2 src/event.js
  2. +14 −5 test/unit/event.js
@@ -388,8 +388,8 @@ jQuery.event = {

for ( cur = event.target; cur != this; cur = cur.parentNode || this ) {

// Don't process events on disabled elements (#6911, #8165)
if ( cur.disabled !== true ) {
// Don't process clicks (ONLY) on disabled elements (#6911, #8165, #xxxx)
if ( cur.disabled !== true || event.type !== "click" ) {
selMatch = {};
matches = [];
jqcur[0] = cur;
@@ -1298,8 +1298,8 @@ test("Delegated events in SVG (#10791)", function() {
svg.remove();
});

test("Delegated events in forms (#10844; #11145; #8165)", function() {
expect(3);
test("Delegated events in forms (#10844; #11145; #8165; #xxxxx)", function() {
expect(5);

// Alias names like "id" cause havoc
var form = jQuery(
@@ -1334,11 +1334,20 @@ test("Delegated events in forms (#10844; #11145; #8165)", function() {
form
.append( '<button id="nestyDisabledBtn"><span>Zing</span></button>' )
.on( "click", "#nestyDisabledBtn", function() {
ok( true, "enabled/disabled button with nesty elements" );
ok( true, "click on enabled/disabled button with nesty elements" );
})
.on( "mouseover", "#nestyDisabledBtn", function() {
ok( true, "mouse on enabled/disabled button with nesty elements" );
})
.find( "span" ).trigger( "click" ).end() // yep
.find( "span" )
.trigger( "click" ) // yep
.trigger( "mouseover" ) // yep
.end()
.find( "#nestyDisabledBtn" ).prop( "disabled", true ).end()
.find( "span" ).trigger( "click" ).end() // nope
.find( "span" )
.trigger( "click" ) // nope
.trigger( "mouseover" ) // yep
.end()
.off( "click" );

form.remove();

0 comments on commit 8a01c92

Please sign in to comment.
You can’t perform that action at this time.