Skip to content
Permalink
Browse files

Ref #13283, move .andSelf() to deprecated.js. Close gh-1170.

  • Loading branch information...
ruado1987 authored and dmethvin committed Feb 27, 2013
1 parent 85f1985 commit 8bc7bdebefb23ef31247dda50012ee19ce9f58af
Showing with 8 additions and 7 deletions.
  1. +1 −0 AUTHORS.txt
  2. +2 −0 src/deprecated.js
  3. +0 −2 src/traversing.js
  4. +1 −1 test/unit/effects.js
  5. +1 −1 test/unit/event.js
  6. +1 −1 test/unit/queue.js
  7. +2 −2 test/unit/traversing.js
@@ -161,3 +161,4 @@ Danil Somsikov <danilasomsikov@gmail.com>
Jean Boussier <jean.boussier@gmail.com>
Adam Coulombe <me@adam.co>
Andrew Plummer <plummer.andrew@gmail.com>
Nguyen Phuc Lam <ruado1987@gmail.com>
@@ -1,4 +1,6 @@
// Limit scope pollution from any deprecated API
// (function() {

jQuery.fn.andSelf = jQuery.fn.addBack;

// })();
@@ -136,8 +136,6 @@ jQuery.fn.extend({
}
});

jQuery.fn.andSelf = jQuery.fn.addBack;

function sibling( cur, dir ) {
while ( (cur = cur[dir]) && cur.nodeType !== 1 ) {}

@@ -1557,7 +1557,7 @@ asyncTest( "hide, fadeOut and slideUp called on element width height and width =
});

asyncTest( "Handle queue:false promises", 10, function() {
var foo = jQuery( "#foo" ).clone().andSelf(),
var foo = jQuery( "#foo" ).clone().addBack(),
step = 1;

foo.animate({
@@ -43,7 +43,7 @@ test("Handler changes and .trigger() order", function() {
path = "";

markup
.find( "*" ).andSelf().on( "click", function( e ) {
.find( "*" ).addBack().on( "click", function( e ) {
path += this.nodeName.toLowerCase() + " ";
})
.filter( "b" ).on( "click", function( e ) {
@@ -184,7 +184,7 @@ test("clearQueue() clears the fx queue", function() {
});

asyncTest( "fn.promise() - called when fx queue is empty", 3, function() {
var foo = jQuery( "#foo" ).clone().andSelf(),
var foo = jQuery( "#foo" ).clone().addBack(),
promised = false;

foo.queue( function( next ) {
@@ -10,7 +10,7 @@ test( "find(String) under non-elements", function() {

var j = jQuery("#nonnodes").contents();
equal( j.find("div").length, 0, "Check node,textnode,comment to find zero divs" );
equal( j.find("div").andSelf().length, 3, "Check node,textnode,comment to find zero divs, but preserves pushStack" );
equal( j.find("div").addBack().length, 3, "Check node,textnode,comment to find zero divs, but preserves pushStack" );
});

test( "find(leading combinator)", function() {
@@ -45,7 +45,7 @@ test( "find(node|jQuery object)", function() {
equal( $two.find( $first ).length, 0, "first is in the collection and not within two" );
equal( $two.find( $first ).length, 0, "first is in the collection and not within two(node)" );

equal( $two.find( $foo[ 0 ] ).andSelf().length, 2, "find preserves the pushStack, see #12009" );
equal( $two.find( $foo[ 0 ] ).addBack().length, 2, "find preserves the pushStack, see #12009" );
});

test("is(String|undefined)", function() {

0 comments on commit 8bc7bde

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.