Skip to content
Permalink
Browse files

jQuery.extend(true, Object, Object) copies objects with length keys c…

…orrectly
  • Loading branch information
wycats committed Jul 16, 2009
1 parent 6b912be commit 8d52c27808a77f51d1cf42c7e738b0b356466c1a
Showing with 8 additions and 2 deletions.
  1. +1 −1 src/core.js
  2. +7 −1 test/unit/core.js
@@ -245,7 +245,7 @@ jQuery.extend = jQuery.fn.extend = function() {
if ( deep && copy && typeof copy === "object" && !copy.nodeType ) {
target[ name ] = jQuery.extend( deep,
// Never move original objects, clone them
src || ( copy.length != null ? [ ] : { } ), copy );
src || ( jQuery.isArray(copy) ? [ ] : { } ), copy );

// Don't bring in undefined values
} else if ( copy !== undefined ) {
@@ -435,7 +435,7 @@ test("jQuery.merge()", function() {
});

test("jQuery.extend(Object, Object)", function() {
expect(20);
expect(21);

var settings = { xnumber1: 5, xnumber2: 7, xstring1: "peter", xstring2: "pan" },
options = { xnumber2: 1, xstring2: "x", xxx: "newstring" },
@@ -460,6 +460,12 @@ test("jQuery.extend(Object, Object)", function() {
isObj( deep2.foo, deep2copy.foo, "Check if not deep2: options must not be modified" );
equals( deep1.foo2, document, "Make sure that a deep clone was not attempted on the document" );

var empty = {};
var optionsWithLength = { foo: { length: -1 } };
jQuery.extend(true, empty, optionsWithLength);

isObj( empty.foo, optionsWithLength.foo, "The length property must copy correctly" );

var nullUndef;
nullUndef = jQuery.extend({}, options, { xnumber2: null });
ok( nullUndef.xnumber2 === null, "Check to make sure null values are copied");

0 comments on commit 8d52c27

Please sign in to comment.
You can’t perform that action at this time.