… retrieval to property when passing class to value functions. Fixes #9617.
- Loading branch information
There are no files selected for viewing
2 comments
on commit 96501d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the bugs site is currently down, I'm grouping the latter part with the first bug. For more information on what I'm fixing there, here's a test case:
Compare jQuery version 1.5.2 and 1.6. - http://jsfiddle.net/timmywil/HqCLn/2/
You'll see "" and "", then undefined and "".
When no class is present, empty string should be passed to value functions. This wasn't caught in the tests in 1.6 because it was just comparing what was returning by attr with what was returned by attr. Not a big one, but will now be consistent and slightly faster as there is no longer a call to attr.
I'll add this info to the bug ticket when the site is back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the second issue that was fixed in this commit: #9624
What is
.removeClass()
supposed to do here?edit: Ah,
value === undefined -> className = ""
, I didn't know that. has been supported ever since 96dd06e. Nice :)