Fixed .val(String) for select elements (#1760) [Thanks Sam]

jquery · Oct 12, 2007 · 971840f · 971840f
1 parent 0f5c1d1
commit 971840f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -407,7 +407,7 @@ jQuery.fn = jQuery.prototype = {
 							jQuery.inArray( this.text, values ) >= 0);
 					});
 
-					if ( !tmp.length )
+					if ( !values.length )
 						this.selectedIndex = -1;
 
 				} else

diff --git a/test/unit/core.js b/test/unit/core.js
@@ -824,11 +824,14 @@ test("val()", function() {
 });
 
 test("val(String)", function() {
-	expect(2);
+	expect(3);
 	document.getElementById('text1').value = "bla";
 	ok( $("#text1").val() == "bla", "Check for modified value of input element" );
 	$("#text1").val('test');
 	ok ( document.getElementById('text1').value == "test", "Check for modified (via val(String)) value of input element" );
+
+	$("#select1").val("3");
+	ok( $("#select1").val() == "3", "Check for modified (via val(String)) value of select element" );
 });
 
 test("html(String)", function() {