Skip to content
Permalink
Browse files

Add a feature test for options inside a disabled select. Follow-up to 1…

  • Loading branch information
jeresig committed Sep 27, 2010
1 parent a384d84 commit 97d468fbf0f840f52c91855b0bc8db0ed6ac403c
Showing with 12 additions and 2 deletions.
  1. +2 −1 src/attributes.js
  2. +10 −1 src/support.js
@@ -164,8 +164,9 @@ jQuery.fn.extend({
var option = options[ i ];

// Don't return options that are disabled or in a disabled optgroup
if ( option.selected && option.getAttribute("disabled") === null &&
if ( option.selected && (jQuery.support.optDisabled ? !option.disabled : option.getAttribute("disabled") === null ) &&
(!option.parentNode.disabled || !jQuery.nodeName( option.parentNode, "optgroup" )) ) {

// Get the specific value for the option
value = jQuery(option).val();

@@ -20,6 +20,9 @@
return;
}

var select = document.createElement("select");
var opt = select.appendChild( document.createElement("option") );

jQuery.support = {
// IE strips leading whitespace when .innerHTML is used
leadingWhitespace: div.firstChild.nodeType === 3,
@@ -56,15 +59,21 @@

// Make sure that a selected-by-default option has a working selected property.
// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
optSelected: document.createElement("select").appendChild( document.createElement("option") ).selected,
optSelected: opt.selected,

// Will be defined later
optDisabled: false,
checkClone: false,
scriptEval: false,
noCloneEvent: true,
boxModel: null
};

// Make sure that the options inside disabled selects aren't marked as disabled
// (WebKit marks them as diabled)
select.disabled = true;
jQuery.support.optDisabled = !opt.disabled;

script.type = "text/javascript";
try {
script.appendChild( document.createTextNode( "window." + id + "=1;" ) );

0 comments on commit 97d468f

Please sign in to comment.
You can’t perform that action at this time.