Skip to content
Permalink
Browse files

Make sure that we don't try to use a detached node (that was in a fra…

…gment) as a fragment in IE. Fixes #5829.
  • Loading branch information
jeresig committed Feb 13, 2010
1 parent 726fda0 commit 99e7560808679b5044dbefb2b7124bb019fdbda2
Showing with 14 additions and 2 deletions.
  1. +1 −1 src/manipulation.js
  2. +2 −0 src/support.js
  3. +11 −1 test/unit/manipulation.js
@@ -321,7 +321,7 @@ jQuery.fn.extend({
parent = value && value.parentNode;

// If we're in a fragment, just use that instead of building a new one
if ( parent && parent.nodeType === 11 && parent.childNodes.length === this.length ) {
if ( jQuery.support.parentNode && parent && parent.nodeType === 11 && parent.childNodes.length === this.length ) {
results = { fragment: parent };

} else {
@@ -56,6 +56,8 @@
// (WebKit defaults to false instead of true, IE too, if it's in an optgroup)
optSelected: document.createElement("select").appendChild( document.createElement("option") ).selected,

parentNode: div.removeChild( div.appendChild( document.createElement("div") ) ).parentNode === null,

// Will be defined later
checkClone: false,
scriptEval: false,
@@ -376,7 +376,8 @@ test("append(Function) with incoming value", function() {
});

test("appendTo(String|Element|Array<Element>|jQuery)", function() {
expect(13);
expect(14);

var defaultText = 'Try them out:'
jQuery('<b>buga</b>').appendTo('#first');
equals( jQuery("#first").text(), defaultText + 'buga', 'Check if text appending works' );
@@ -429,6 +430,15 @@ test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
jQuery("<span>a</span><b>b</b>").filter("span").appendTo( div );

equals( div.children().length, 1, "Make sure the right number of children were inserted." );

div = jQuery("#moretests div");

var num = jQuery("#main div").length;
div.remove().appendTo("#main");

equals( jQuery("#main div").length, num, "Make sure all the removed divs were inserted." );

reset();
});

var testPrepend = function(val) {

0 comments on commit 99e7560

Please sign in to comment.
You can’t perform that action at this time.