Skip to content
Permalink
Browse files

Selector: Update Sizzle

Fixes #14657
  • Loading branch information...
gibson042 committed Jan 13, 2014
1 parent 478cf37 commit 9ac88dea494b0b79d1e1d1d26f8d9f5eb670cf62
Showing with 1 addition and 1 deletion.
  1. +1 −1 bower.json
@@ -13,7 +13,7 @@
"bower.json"
],
"dependencies": {
"sizzle": "1.10.15"
"sizzle": "1.10.16"
},
"devDependencies": {
"requirejs": "~2.1.8",

15 comments on commit 9ac88de

@markelog

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

You didn't update it, see bowercopy task.
cc @timmywil

@dmethvin

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

Been here, done this but with sinon timers. I don't know if the process is inherently error prone or we just need some better instructions than the commit message at f9ad13c .

@markelog

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

@timmywil well, i think "i told you so" would be in order :-)

@dmethvin

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

It must have seemed like a good idea at the time 😸 Worse things happened to me with submodules but I've blocked them out.

@timmywil

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

I talked with @gibson042 over IRC when the workflow changed. I think he just had a brain fart.

@timmywil

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

@markelog I reciprocate your "I told you so" with a "We commit dependencies now. Deal with it."

@mgol

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

How about putting the commit message from f9ad13c into a comment before the bower alias definition in Gruntfile?

@timmywil

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

How about putting the commit message from f9ad13c into a comment before the bower alias definition in Gruntfile?

Sounds good to me. Should we put it in the README as well?

@mgol

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

We could but README is not only for commiters and other developers don't really have to care about this issue.

@timmywil

This comment has been minimized.

Copy link
Member

replied Jan 13, 2014

Yea, that's pretty much why I haven't put it somewhere. Ok, in the Gruntfile seems like a good place.

@gibson042

This comment has been minimized.

Copy link
Member Author

replied Jan 15, 2014

Aargh! @timmywil is right, but this just doesn't seem workable unless the default grunt task detects the need to invoke bower and does so automatically.

@markelog

This comment has been minimized.

Copy link
Member

replied Jan 15, 2014

What use case would be for that? How you usually update Sizzle? Do you update bower.json then run grunt default, or just update and commit it without executing any command?

@gibson042

This comment has been minimized.

Copy link
Member Author

replied Jan 15, 2014

  1. Update source of truth (currently bower.json)
  2. Apply (currently bower update; grunt)
  3. Confirm (in this case I only ran unit tests, but should have also checked the compiled source)
@markelog

This comment has been minimized.

Copy link
Member

replied Jan 15, 2014

currently `bower update`
i guess not "currently", since we you use grunt task for it for quite some time now.

So basically, now you replace bower update with grunt bower plus commit newly updated dependency, i guess detect changes of bower.json file would be easy enough to do but in that case you should have to remember to make commit after grunt default command.

@gibson042

This comment has been minimized.

Copy link
Member Author

replied Jan 15, 2014

😐
The universe always promises a bigger idiot. Today, that role is mine.

Please sign in to comment.
You can’t perform that action at this time.