Been here, done this but with sinon timers. I don't know if the process is inherently error prone or we just need some better instructions than the commit message at f9ad13c .
Aargh! @timmywil is right, but this just doesn't seem workable unless the default grunt task detects the need to invoke bower and does so automatically.
What use case would be for that? How you usually update Sizzle? Do you update bower.json then run grunt default, or just update and commit it without executing any command?
i guess not "currently", since we you use grunt task for it for quite some time now.
So basically, now you replace bower update with grunt bower plus commit newly updated dependency, i guess detect changes of bower.json file would be easy enough to do but in that case you should have to remember to make commit after grunt default command.
This comment has been minimized.
markelog repliedJan 13, 2014
You didn't update it, see
bowercopytask.cc @timmywil
This comment has been minimized.
dmethvin repliedJan 13, 2014
Been here, done this but with sinon timers. I don't know if the process is inherently error prone or we just need some better instructions than the commit message at f9ad13c .
This comment has been minimized.
markelog repliedJan 13, 2014
@timmywil well, i think "i told you so" would be in order :-)
This comment has been minimized.
dmethvin repliedJan 13, 2014
It must have seemed like a good idea at the time😸 Worse things happened to me with submodules but I've blocked them out.
This comment has been minimized.
timmywil repliedJan 13, 2014
I talked with @gibson042 over IRC when the workflow changed. I think he just had a brain fart.
This comment has been minimized.
timmywil repliedJan 13, 2014
@markelog I reciprocate your "I told you so" with a "We commit dependencies now. Deal with it."
This comment has been minimized.
mgol repliedJan 13, 2014
How about putting the commit message from f9ad13c into a comment before the
boweralias definition in Gruntfile?This comment has been minimized.
timmywil repliedJan 13, 2014
Sounds good to me. Should we put it in the README as well?
This comment has been minimized.
mgol repliedJan 13, 2014
We could but README is not only for commiters and other developers don't really have to care about this issue.
This comment has been minimized.
timmywil repliedJan 13, 2014
Yea, that's pretty much why I haven't put it somewhere. Ok, in the Gruntfile seems like a good place.
This comment has been minimized.
gibson042 repliedJan 15, 2014
Aargh! @timmywil is right, but this just doesn't seem workable unless the default grunt task detects the need to invoke
bowerand does so automatically.This comment has been minimized.
markelog repliedJan 15, 2014
What use case would be for that? How you usually update Sizzle? Do you update
bower.jsonthen rungrunt default, or just update and commit it without executing any command?This comment has been minimized.
gibson042 repliedJan 15, 2014
bower update;grunt)This comment has been minimized.
markelog repliedJan 15, 2014
So basically, now you replace
bower updatewithgrunt bowerplus commit newly updated dependency, i guess detect changes ofbower.jsonfile would be easy enough to do but in that case you should have to remember to make commit aftergrunt defaultcommand.This comment has been minimized.
gibson042 repliedJan 15, 2014
The universe always promises a bigger idiot. Today, that role is mine.