Permalink
15 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | ||
| "bower.json" | ||
| ], | ||
| "dependencies": { | ||
| "sizzle": "1.10.16" | ||
| }, | ||
| "devDependencies": { | ||
| "requirejs": "~2.1.8", | ||
This comment has been minimized.
You didn't update it, see
bowercopytask.cc @timmywil
This comment has been minimized.
Been here, done this but with sinon timers. I don't know if the process is inherently error prone or we just need some better instructions than the commit message at f9ad13c .
This comment has been minimized.
@timmywil well, i think "i told you so" would be in order :-)
This comment has been minimized.
It must have seemed like a good idea at the time😸 Worse things happened to me with submodules but I've blocked them out.
This comment has been minimized.
I talked with @gibson042 over IRC when the workflow changed. I think he just had a brain fart.
This comment has been minimized.
@markelog I reciprocate your "I told you so" with a "We commit dependencies now. Deal with it."
This comment has been minimized.
How about putting the commit message from f9ad13c into a comment before the
boweralias definition in Gruntfile?This comment has been minimized.
Sounds good to me. Should we put it in the README as well?
This comment has been minimized.
We could but README is not only for commiters and other developers don't really have to care about this issue.
This comment has been minimized.
Yea, that's pretty much why I haven't put it somewhere. Ok, in the Gruntfile seems like a good place.
This comment has been minimized.
Aargh! @timmywil is right, but this just doesn't seem workable unless the default grunt task detects the need to invoke
bowerand does so automatically.This comment has been minimized.
What use case would be for that? How you usually update Sizzle? Do you update
bower.jsonthen rungrunt default, or just update and commit it without executing any command?This comment has been minimized.
bower update;grunt)This comment has been minimized.
So basically, now you replace
bower updatewithgrunt bowerplus commit newly updated dependency, i guess detect changes ofbower.jsonfile would be easy enough to do but in that case you should have to remember to make commit aftergrunt defaultcommand.This comment has been minimized.
The universe always promises a bigger idiot. Today, that role is mine.