Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Blackberry 4.6 doesn't maintain comment nodes in the DOM, ignore them…
… in our test cases.
- Loading branch information
Showing
1 changed file
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ce1d09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So blackberry just drops the comment node, huh?
Why make assertions on presence of comments though?
The assertion message does not completely match what the assertion does. Do you think the test assertion is too complicated?
9ce1d09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion on comment nodes is rather important as we need to make sure that the text and wrapping methods handle them correctly in all the browsers that support comments. Since they appear to not exist in the Blackberry DOM at this point in the test it's kind of a moot point.