Skip to content
Permalink
Browse files

Don't run direct handlers if delegate did .stopPropagation().

  • Loading branch information...
dmethvin committed Oct 21, 2011
1 parent c4cc343 commit 9fabe2028f05bc409f937ff7cd71caaacd26f945
Showing with 17 additions and 1 deletion.
  1. +1 −1 src/event.js
  2. +16 −0 test/unit/event.js
@@ -459,7 +459,7 @@ jQuery.event = {
delete event.delegateTarget;

// Run non-delegated handlers for this level
if ( handlers.length ) {
if ( handlers.length && !event.isPropagationStopped() ) {
dispatch( this, event, handlers, args );
}

@@ -2054,6 +2054,22 @@ test(".delegate()/.undelegate()", function() {
jQuery("#body").undelegate("#nothiddendiv div", "click");
});

test("stopPropagation() stops directly-bound events on delegated target", function() {
expect(1);

var markup = jQuery( '<div><p><a href="#">target</a></p></div>' );
markup
.on( "click", function() {
ok( false, "directly-bound event on delegate target was called" );
})
.on( "click", "a", function( e ) {
e.stopPropagation();
ok( true, "delegated handler was called" );
})
.find("a").click().end()
.remove();
});

test("undelegate all bound events", function(){
expect(1);

0 comments on commit 9fabe20

Please sign in to comment.
You can’t perform that action at this time.