Skip to content
Permalink
Browse files

Manipulation: Use textarea for missing IE defaultValue check

IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue when it
doesn't need to be done is not a problem, so leave that code for IE11.

Fixes #14716
Closes gh-1495
  • Loading branch information...
dmethvin committed Jan 22, 2014
1 parent 3f3f458 commit a20494228d51c57c454ff9f10a4ba8bbdda0e49c
Showing with 6 additions and 9 deletions.
  1. +5 −8 src/manipulation/support.js
  2. +1 −1 test/unit/support.js
@@ -3,8 +3,7 @@ define([
], function( support ) {

(function() {
var input,
fragment = document.createDocumentFragment(),
var fragment = document.createDocumentFragment(),
div = fragment.appendChild( document.createElement( "div" ) );

// #11217 - WebKit loses check when the name is after the checked attribute
@@ -14,12 +13,10 @@ define([
// old WebKit doesn't clone checked state correctly in fragments
support.checkClone = div.cloneNode( true ).cloneNode( true ).lastChild.checked;

// Make sure checked status is properly cloned
// Support: IE9, IE10
input = document.createElement("input");
input.type = "checkbox";
input.checked = true;
support.noCloneChecked = input.cloneNode( true ).checked;
// Make sure textarea (and checkbox) defaultValue is properly cloned
// Support: IE9-IE11+
div.innerHTML = "<textarea>x</textarea>";
support.noCloneChecked = !!div.cloneNode( true ).lastChild.defaultValue;
})();

return support;
@@ -92,7 +92,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"clearCloneStyle": false,
"cors": true,
"focusinBubbles": true,
"noCloneChecked": true,
"noCloneChecked": false,
"optDisabled": true,
"optSelected": false,
"pixelPosition": true,

0 comments on commit a204942

Please sign in to comment.
You can’t perform that action at this time.