Skip to content
Permalink
Browse files

Made sure that .remove now uses multiFilter. Fixes bug #4205.

  • Loading branch information
jeresig committed Feb 20, 2009
1 parent db62240 commit a37ca9e9058243169725982e91bce60801b9857d
Showing with 5 additions and 2 deletions.
  1. +1 −1 src/core.js
  2. +4 −1 test/unit/core.js
@@ -1224,7 +1224,7 @@ jQuery.each({
},

remove: function( selector ) {
if ( !selector || jQuery.filter( selector, [ this ] ).length ) {
if ( !selector || jQuery.multiFilter( selector, [ this ] ).length ) {
// Prevent memory leaks
jQuery( "*", this ).add([this]).each(function(){
jQuery.event.remove(this);
@@ -1713,7 +1713,7 @@ test("jQuery.className", function() {
});

test("remove()", function() {
expect(6);
expect(7);
jQuery("#ap").children().remove();
ok( jQuery("#ap").text().length > 10, "Check text is not removed" );
equals( jQuery("#ap").children().length, 0, "Check remove" );
@@ -1723,6 +1723,9 @@ test("remove()", function() {
ok( jQuery("#ap").text().length > 10, "Check text is not removed" );
equals( jQuery("#ap").children().length, 1, "Check filtered remove" );

jQuery("#ap").children().remove("a, code");
equals( jQuery("#ap").children().length, 0, "Check multi-filtered remove" );

// using contents will get comments regular, text, and comment nodes
equals( jQuery("#nonnodes").contents().length, 3, "Check node,textnode,comment remove works" );
jQuery("#nonnodes").contents().remove();

0 comments on commit a37ca9e

Please sign in to comment.
You can’t perform that action at this time.