Skip to content
Permalink
Browse files

jquery core: Simplifying isEmptyObject() and adding tests.

  • Loading branch information
flesler committed Jul 16, 2009
1 parent 991d039 commit a38a5cd531a328319f8b7f3f33a84044b54591ce
Showing with 13 additions and 3 deletions.
  1. +3 −3 src/core.js
  2. +10 −0 test/unit/core.js
@@ -292,9 +292,9 @@ jQuery.extend({
},

isEmptyObject: function( obj ) {
var name = "";
for(name in obj) break;
return !name;
for(var name in obj)
return false;
return true;
},

// check if an element is in a (or is an) XML document
@@ -599,3 +599,13 @@ test("jQuery.makeArray", function(){

ok( jQuery.makeArray(document.getElementById('form')).length >= 13, "Pass makeArray a form (treat as elements)" );
});

test("jQuery.isEmptyObject", function(){
expect(2);

equals(true, jQuery.isEmptyObject({}), "isEmptyObject on empty object literal" );
equals(false, jQuery.isEmptyObject({a:1}), "isEmptyObject on non-empty object literal" );

// What about this ?
// equals(true, jQuery.isEmptyObject(null), "isEmptyObject on null" );
});

0 comments on commit a38a5cd

Please sign in to comment.
You can’t perform that action at this time.