Skip to content
Permalink
Browse files

selectedIndex is now cloned cross-browser (#1294)

  • Loading branch information
brandonaaron committed Jul 21, 2007
1 parent 9b9a793 commit a65a811ce03b2f7900ae0daa18d4d9fc213acbfd
Showing with 14 additions and 8 deletions.
  1. +14 −8 src/jquery/jquery.js
@@ -852,9 +852,10 @@ jQuery.fn = jQuery.prototype = {
* @cat DOM/Manipulation
*/
clone: function(deep) {
deep = deep != undefined ? deep : true
var $this = this.add(this.find("*"));
if (jQuery.browser.msie) {
// Need to remove events on the element and its descendants
var $this = this.add(this.find("*"));
$this.each(function() {
this._$events = {};
for (var type in this.$events)
@@ -864,23 +865,28 @@ jQuery.fn = jQuery.prototype = {

// Do the clone
var r = this.pushStack( jQuery.map( this, function(a){
return a.cloneNode( deep != undefined ? deep : true );
return a.cloneNode( deep );
}) );

if (jQuery.browser.msie) {
// Add the events back to the original and its descendants
$this.each(function() {
// Add the events back to the original and its descendants
var events = this._$events;
for (var type in events)
for (var handler in events[type])
jQuery.event.add(this, type, events[type][handler], events[type][handler].data);
this._$events = null;
});

// set selected values of select elements
var selects = r.find('select');
$this.filter('select').each(function(i) {
selects[i].selectedIndex = this.selectedIndex;
}

// copy form values over
if (deep) {
var inputs = r.add(r.find('*')).filter('select,input[@type=checkbox]');
$this.filter('select,input[@type=checkbox]').each(function(i) {
if (this.selectedIndex)
inputs[i].selectedIndex = this.selectedIndex;
if (this.checked)
inputs[i].checked = true;
});
}

0 comments on commit a65a811

Please sign in to comment.
You can’t perform that action at this time.