Permalink
Browse files

CSS: Use pre-defined displays for html and body

  • Loading branch information...
markelog committed Sep 2, 2014
1 parent 274feb5 commit a7724186c98734529b06bebb8f2dc7fc2b641011
Showing with 7 additions and 1 deletion.
  1. +7 −1 src/css/defaultDisplay.js
@@ -4,7 +4,13 @@ define([
], function( jQuery ) {
var iframe,
elemdisplay = {};
elemdisplay = {
// Support: Firefox
// We have to pre-define this values for FF (#10227)

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Sep 2, 2014

Member

@bzbarsky i guess nothing happend on this front?

Also see 274feb5

@markelog

markelog Sep 2, 2014

Member

@bzbarsky i guess nothing happend on this front?

Also see 274feb5

HTML: "block",
BODY: "block"
};
/**
* Retrieve the actual display of a element

3 comments on commit a772418

@bzbarsky

This comment has been minimized.

Show comment
Hide comment
@bzbarsky

bzbarsky Sep 2, 2014

@markelog https://bugzilla.mozilla.org/show_bug.cgi?id=800983 has been fixed since Firefox 19. jQuery just needs to use the API if it wants to... Sounds like someone thought its use was an "optimization", not a correctness fix in jQuery....

@markelog https://bugzilla.mozilla.org/show_bug.cgi?id=800983 has been fixed since Firefox 19. jQuery just needs to use the API if it wants to... Sounds like someone thought its use was an "optimization", not a correctness fix in jQuery....

@bzbarsky

This comment has been minimized.

Show comment
Hide comment
@bzbarsky

bzbarsky Sep 2, 2014

@markelog Or did you mean something else by "this"? The comment you linked to explains why what jQuery is doing right now is totally unreliable and proposes adding an API to let jQuery ask for the information it actually wants. The API was then implemented, after buy-in from the CSSWG, then the CSSWG decided to jerk everyone around and changed the API again. Once they decide what the heck they actually want, Gecko will implement the new API, of course.

That said, it sounds like Polymer is breaking createElement pretty badly by making it return things that aren't actually element instances! Have you considered filing a bug on them about that?

@markelog Or did you mean something else by "this"? The comment you linked to explains why what jQuery is doing right now is totally unreliable and proposes adding an API to let jQuery ask for the information it actually wants. The API was then implemented, after buy-in from the CSSWG, then the CSSWG decided to jerk everyone around and changed the API again. Once they decide what the heck they actually want, Gecko will implement the new API, of course.

That said, it sounds like Polymer is breaking createElement pretty badly by making it return things that aren't actually element instances! Have you considered filing a bug on them about that?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Sep 2, 2014

Member

Sounds like someone thought its use was an "optimization", not a correctness fix in jQuery

I just forgot it was used used not only as an optimization fix

That said, it sounds like Polymer is breaking createElement pretty badly by making it return things that aren't actually element instances! Have you considered filing a bug on them about that?

They already fix that - Polymer/polymer#686

just needs to use the API if it wants to

Using of a method that is not implemented anywhere else is an overkill, we were hoping we could replace it with something that most browsers would have, this issue was a remainder to stop waiting i suppose.

API was then implemented, after buy-in from the CSSWG, then the CSSWG decided to jerk everyone around and changed the API again

:-(, sad news indeed

/cc @dmethvin

Member

markelog replied Sep 2, 2014

Sounds like someone thought its use was an "optimization", not a correctness fix in jQuery

I just forgot it was used used not only as an optimization fix

That said, it sounds like Polymer is breaking createElement pretty badly by making it return things that aren't actually element instances! Have you considered filing a bug on them about that?

They already fix that - Polymer/polymer#686

just needs to use the API if it wants to

Using of a method that is not implemented anywhere else is an overkill, we were hoping we could replace it with something that most browsers would have, this issue was a remainder to stop waiting i suppose.

API was then implemented, after buy-in from the CSSWG, then the CSSWG decided to jerk everyone around and changed the API again

:-(, sad news indeed

/cc @dmethvin

Please sign in to comment.