Permalink
Browse files

Focused support of .live(). stopPropagation and stopImmediatePropagat…

…ion are not supported - and do not do what the use would expect.
  • Loading branch information...
1 parent 28a1f02 commit a78557472ce1c2cdf7db01a13fcc8591f3fdcfb0 @jeresig jeresig committed Jan 20, 2009
Showing with 12 additions and 4 deletions.
  1. +2 −3 src/event.js
  2. +10 −1 test/unit/event.js
View
@@ -572,9 +572,8 @@ function liveHandler( event ){
});
jQuery.each(elems, function(){
- if ( !event.isImmediatePropagationStopped() &&
- this.fn.call(this.elem, event, this.fn.data) === false )
- stop = false;
+ if ( this.fn.call(this.elem, event, this.fn.data) === false )
+ stop = false;
});
return stop;
View
@@ -474,7 +474,7 @@ test("toggle(Function, Function, ...)", function() {
});
test(".live()/.die()", function() {
- expect(38);
+ expect(42);
var submit = 0, div = 0, livea = 0, liveb = 0;
@@ -533,6 +533,15 @@ test(".live()/.die()", function() {
equals( livea, 5, "die Click on inner div" );
equals( liveb, 2, "die Click on inner div" );
+ // Make sure that stopPropgation doesn't stop live events
+ jQuery("div#nothiddendivchild").live("click", function(e){ liveb++; e.stopPropagation(); });
+ jQuery("div#nothiddendivchild").trigger("click");
+ equals( submit, 1, "stopPropagation Click on inner div" );
+ equals( div, 6, "stopPropagation Click on inner div" );
+ equals( livea, 6, "stopPropagation Click on inner div" );
+ equals( liveb, 3, "stopPropagation Click on inner div" );
+
+ jQuery("div#nothiddendivchild").die("click");
jQuery("div#nothiddendiv").die("click");
jQuery("div").die("click");
jQuery("div").die("submit");

0 comments on commit a785574

Please sign in to comment.