Fixes #7369 - Using an attribute selector for a non-existent attribut…

…e raised an exception on disconnected nodes
jquery · Mar 31, 2011 · a807451a23577ad04140a32f7888e6c7b26a8838 · a807451
1 parent 6c28a39
commit a807451a23577ad04140a32f7888e6c7b26a8838
Unified Split

Showing with 6 additions and 2 deletions.

+1 −1 src/traversing.js

+5 −1 test/unit/traversing.js
diff --git a/src/traversing.js b/src/traversing.js
@@ -112,7 +112,7 @@ jQuery.fn.extend({
 
 				} else {
 					cur = cur.parentNode;
-					if ( !cur || !cur.ownerDocument || cur === context ) {
+					if ( !cur || !cur.ownerDocument || cur === context || cur.nodeType === 11 ) {
 						break;
 					}
 				}

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
@@ -124,7 +124,7 @@ test("filter(jQuery)", function() {
 })
 
 test("closest()", function() {
-	expect(11);
+	expect(13);
 	same( jQuery("body").closest("body").get(), q("body"), "closest(body)" );
 	same( jQuery("body").closest("html").get(), q("html"), "closest(html)" );
 	same( jQuery("body").closest("div").get(), [], "closest(div)" );
@@ -144,6 +144,10 @@ test("closest()", function() {
 
 	// Test on disconnected node
 	equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." );
+
+	// Bug #7369
+	equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" );
+	equals( jQuery('<div>text</div>').closest('[lang]').length, 0, "Disconnected nodes with text and non-existent attribute selector" );
 });
 
 test("closest(Array)", function() {