Fix for #883

jquery · Jan 31, 2007 · a82b048 · a82b048
1 parent 4e256bf
commit a82b048
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/jquery/coreTest.js b/src/jquery/coreTest.js
@@ -102,14 +102,16 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(6);
+	expect(7);
 	var div = $("div");
 	div.attr("foo", "bar");
 	var pass = true;
 	for ( var i = 0; i < div.size(); i++ ) {
 	  if ( div.get(i).getAttribute('foo') != "bar" ) pass = false;
 	}
 	ok( pass, "Set Attribute" );
+
+	ok( $("#foo").attr({"width": null}), "Try to set an attribute to nothing" );	
 
 	$("#name").attr('name', 'something');
 	ok( $("#name").attr('name') == 'something', 'Set name attribute' );

diff --git a/src/jquery/jquery.js b/src/jquery/jquery.js
@@ -1281,7 +1281,7 @@ jQuery.extend({
 			var exclude = /z-?index|font-?weight|opacity|zoom|line-?height/i;
 
 			// Handle passing in a number to a CSS property
-			if ( value.constructor == Number && type == "curCSS" && !exclude.test(prop) )
+			if ( value && value.constructor == Number && type == "curCSS" && !exclude.test(prop) )
 				return value + "px";
 
 			return value;