Permalink
Browse files

Added support for a[name^='foo['] style selectors. Fies jQuery bug #3…

…928.
  • Loading branch information...
1 parent cd28922 commit aa7616cf9aac1692a483165144a42cde9a3169e0 @jeresig jeresig committed Jan 20, 2009
Showing with 16 additions and 4 deletions.
  1. +1 −1 src/selector.js
  2. +1 −1 test/index.html
  3. +14 −2 test/unit/selector.js
View
@@ -6,7 +6,7 @@
*/
(function(){
-var chunker = /((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^[\]]*\]|[^[\]]+)+\]|\\.|[^ >+~,(\[]+)+|[>+~])(\s*,\s*)?/g,
+var chunker = /((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^[\]]*\]|['"][^'"]+['"]|[^[\]'"]+)+\]|\\.|[^ >+~,(\[]+)+|[>+~])(\s*,\s*)?/g,
done = 0,
toString = Object.prototype.toString;
View
@@ -39,7 +39,7 @@ <h2 id="userAgent"></h2>
<p id="firstp">See <a id="simon1" href="http://simon.incutio.com/archive/2003/03/25/#getElementsBySelector" rel="bookmark">this blog entry</a> for more information.</p>
<p id="ap">
Here are some links in a normal paragraph: <a id="google" href="http://www.google.com/" title="Google!">Google</a>,
- <a id="groups" href="http://groups.google.com/">Google Groups</a>.
+ <a id="groups" href="http://groups.google.com/">Google Groups (Link)</a>.
This link has <code><a href="http://smin" id="anchor1">class="blog"</a></code>:
<a href="http://diveintomark.org/" class="blog" hreflang="en" id="mark">diveintomark</a>
View
@@ -197,7 +197,7 @@ test("child and adjacent", function() {
});
test("attributes", function() {
- expect(27);
+ expect(34);
t( "Attribute Exists", "a[title]", ["google"] );
t( "Attribute Exists", "*[title]", ["google"] );
t( "Attribute Exists", "[title]", ["google"] );
@@ -221,6 +221,14 @@ test("attributes", function() {
if ( document.querySelectorAll ) {
results = ["radio1", "radio2", "hidden1"];
}
+
+ t( "Attribute containing []", "input[name^='foo[']", ["hidden2"] );
+ t( "Attribute containing []", "input[name^='foo[bar]']", ["hidden2"] );
+ t( "Attribute containing []", "input[name*='[bar]']", ["hidden2"] );
+ t( "Attribute containing []", "input[name$='bar]']", ["hidden2"] );
+ t( "Attribute containing []", "input[name$='[bar]']", ["hidden2"] );
+ t( "Attribute containing []", "input[name$='foo[bar]']", ["hidden2"] );
+ t( "Attribute containing []", "input[name*='foo[bar]']", ["hidden2"] );
t( "Multiple Attribute Equals", "#form input[type='hidden'],#form input[type='radio']", results );
t( "Multiple Attribute Equals", "#form input[type=\"hidden\"],#form input[type='radio']", results );
@@ -244,7 +252,7 @@ test("attributes", function() {
});
test("pseudo (:) selectors", function() {
- expect(51);
+ expect(53);
t( "First Child", "p:first-child", ["firstp","sndp"] );
t( "Last Child", "p:last-child", ["sap"] );
t( "Only Child", "a:only-child", ["simon1","anchor1","yahoo","anchor2"] );
@@ -255,6 +263,10 @@ test("pseudo (:) selectors", function() {
t( "Selected Option Element", "#form option:selected", ["option1a","option2d","option3b","option3c"] );
t( "Text Contains", "a:contains('Google')", ["google","groups"] );
t( "Text Contains", "a:contains('Google Groups')", ["groups"] );
+
+ t( "Text Contains", "a:contains('Google Groups (Link)')", ["groups"] );
+ t( "Text Contains", "a:contains('(Link)')", ["groups"] );
+
t( "Element Preceded By", "p ~ div", ["foo","fx-queue","fx-tests", "moretests","tabindex-tests"] );
t( "Not", "a.blog:not(.link)", ["mark"] );
t( "Not - multiple", "#form option:not(:contains('Nothing'),#option1b,:selected)", ["option1c", "option1d", "option2b", "option2c", "option3d", "option3e"] );

0 comments on commit aa7616c

Please sign in to comment.