Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
2 changed files
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -194,7 +194,9 @@ function ajaxTest( title, expect, options ) { | ||
options.afterSend( request ); | ||
} | ||
|
||
return request.then( callIfDefined( "done", "success" ), callIfDefined( "fail", "error" ) ); | ||
return request | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dmethvin
Member
|
||
.done( callIfDefined( "done", "success" ) ) | ||
.fail( callIfDefined( "fail", "error" ) ); | ||
}); | ||
|
||
jQuery.when.apply( jQuery, requests ).always( complete, options.teardown, start); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see this passes in testswarm but i have a feeling it's just by luck (and I have a feeling that's what makes test fail in IE10)... Now we feed
$.when
requests that will fail and will immediately end the join. Maybe using a counter (a modification ofcomplete
could handle it and be fed to the done and fail calls) would help achieve what you're looking for (rather than$.when
)... it would also fix our concerns regarding speed by limiting the overhead of usingajaxTest
.