Skip to content
Permalink
Browse files

Fix #13809: Avoid collisions with words reserved by any version of EC…

…MA-262
  • Loading branch information...
gibson042 committed Apr 24, 2013
1 parent d8f7e83 commit ad71f47b27f463c6952768c5ab2773ae15ffa745
Showing with 4 additions and 4 deletions.
  1. +3 −3 src/attributes.js
  2. +1 −1 src/sizzle
@@ -305,7 +305,7 @@ jQuery.extend({
if ( nType !== 1 || !jQuery.isXMLDoc( elem ) ) {
name = name.toLowerCase();
hooks = jQuery.attrHooks[ name ] ||
( jQuery.expr.match.boolean.test( name ) ? boolHook : nodeHook );
( jQuery.expr.match.bool.test( name ) ? boolHook : nodeHook );
}

if ( value !== undefined ) {
@@ -344,7 +344,7 @@ jQuery.extend({
propName = jQuery.propFix[ name ] || name;

// Boolean attributes get special treatment (#10870)
if ( jQuery.expr.match.boolean.test( name ) ) {
if ( jQuery.expr.match.bool.test( name ) ) {
// Set corresponding property to false
elem[ propName ] = false;
}
@@ -428,7 +428,7 @@ boolHook = {
return name;
}
};
jQuery.each( jQuery.expr.match.boolean.source.match( /\w+/g ), function( i, name ) {
jQuery.each( jQuery.expr.match.bool.source.match( /\w+/g ), function( i, name ) {

This comment has been minimized.

Copy link
@unjust

unjust May 6, 2013

I just updated and am doing a custom build. jQuery.expr.match.bool seems to be undefined. This is my build command: grunt custom:-effects,-deprecated,-event-alias,-dimensions,-wrap,-sizzle

This comment has been minimized.

Copy link
@rwaldron

rwaldron May 6, 2013

Member

Is that a bug report or general conversation? Seems like a bug report... those go here: http://bugs.jquery.com

This comment has been minimized.

Copy link
@timmywil

timmywil May 6, 2013

Member

It should already be fixed. selector-native needed the name change as well.

This comment has been minimized.

Copy link
@unjust

unjust May 6, 2013

Ok I will check. Thanks for the response. And sorry about posting a bug in the wrong place, I couldn't find where to post bugs/issues on the jquery github homepage.

var getter = jQuery.expr.attrHandle[ name ] || jQuery.find.attr;

jQuery.expr.attrHandle[ name ] = function( elem, name, isXML ) {
Submodule sizzle updated 4 files
+2 −2 dist/sizzle.js
+1 −1 dist/sizzle.min.js
+1 −1 dist/sizzle.min.map
+1 −1 sizzle.js

0 comments on commit ad71f47

Please sign in to comment.
You can’t perform that action at this time.