Skip to content
Permalink
Browse files

Fix #12534. Don't die on browsers lacking getBoundingClientRect.

  • Loading branch information...
dmethvin committed Sep 13, 2012
1 parent 74cdd78 commit b0a352bfa76cbe1b65f8186d3cb90fe35a08866d
Showing with 11 additions and 2 deletions.
  1. +2 −2 src/offset.js
  2. +9 −0 test/unit/offset.js
@@ -23,8 +23,8 @@ jQuery.fn.offset = function( options ) {

docElem = doc.documentElement;

// Make sure we're not dealing with a disconnected DOM node
if ( !jQuery.contains( docElem, elem ) ) {
// Make sure we have the API and we're it's not a disconnected DOM node

This comment has been minimized.

Copy link
@dmethvin

dmethvin Sep 14, 2012

Author Member

GAAH!

if ( typeof elem.getBoundingClientRect === "undefined" || !jQuery.contains( docElem, elem ) ) {
return { top: 0, left: 0 };
}

@@ -15,6 +15,15 @@ test("empty set", function() {
strictEqual( jQuery().position(), undefined, "position() returns undefined for empty set (#11962)" );
});

test("object without getBoundingClientRect", function() {
expect(2);

// Simulates a browser without gBCR on elements, we just want to return 0,0
var result = jQuery({ ownerDocument: document }).offset();
equal( result.top, 0, "Check top" );
equal( result.left, 0, "Check left" );
});

test("disconnected node", function() {
expect(2);

0 comments on commit b0a352b

Please sign in to comment.
You can’t perform that action at this time.