Skip to content
Permalink
Browse files
Calling load with null as the data parameter now properly issues a GE…
…T request, not a POST request. Unit tests added. Fixes #12234.
  • Loading branch information
jaubourg committed Aug 16, 2012
1 parent aa1350d commit b292c4c
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 2 deletions.
@@ -170,7 +170,7 @@ jQuery.fn.load = function( url, params, callback ) {
params = undefined;

// Otherwise, build a param string
} else if ( typeof params === "object" ) {
} else if ( params && typeof params === "object" ) {
type = "POST";
}

@@ -1037,11 +1037,45 @@ test("global ajaxSettings", function() {
*/

test("load(String)", function() {
expect(1);
expect(2);
stop(); // check if load can be called with only url
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", function() {
start();
});
jQuery.ajaxSetup({
beforeSend: null
});
});

test("load(String,null)", function() {
expect(2);
stop(); // check if load can be called with url and null data
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", null, function() {
start();
});
});

test("load(String,undefined)", function() {
expect(2);
stop(); // check if load can be called with url and null data
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", undefined, function() {
start();
});
});

test("load('url selector')", function() {

1 comment on commit b292c4c

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.