Skip to content
Permalink
Browse files

Calling load with null as the data parameter now properly issues a GE…

…T request, not a POST request. Unit tests added. Fixes #12234.
  • Loading branch information...
jaubourg committed Aug 16, 2012
1 parent aa1350d commit b292c4c2df673d17d8c720e13d4d81ecae4ec499
Showing with 36 additions and 2 deletions.
  1. +1 −1 src/ajax.js
  2. +35 −1 test/unit/ajax.js
@@ -170,7 +170,7 @@ jQuery.fn.load = function( url, params, callback ) {
params = undefined;

// Otherwise, build a param string
} else if ( typeof params === "object" ) {
} else if ( params && typeof params === "object" ) {
type = "POST";
}

@@ -1037,11 +1037,45 @@ test("global ajaxSettings", function() {
*/

test("load(String)", function() {
expect(1);
expect(2);
stop(); // check if load can be called with only url
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", function() {
start();
});
jQuery.ajaxSetup({
beforeSend: null
});
});

test("load(String,null)", function() {
expect(2);
stop(); // check if load can be called with url and null data
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", null, function() {
start();
});
});

test("load(String,undefined)", function() {
expect(2);
stop(); // check if load can be called with url and null data
jQuery.ajaxSetup({
beforeSend: function() {
strictEqual( this.type, "GET", "no data means GET request" );
}
});
jQuery("#first").load("data/name.html", undefined, function() {
start();
});
});

test("load('url selector')", function() {

1 comment on commit b292c4c

@jzaefferer

This comment has been minimized.

Please sign in to comment.
You can’t perform that action at this time.